diff options
| author | Samuel Pitoiset <[email protected]> | 2019-10-21 16:03:47 +0200 |
|---|---|---|
| committer | Dylan Baker <[email protected]> | 2019-10-25 09:06:25 -0700 |
| commit | e8d4a75d9a4826f5f94ac62865dde5235cb85daa (patch) | |
| tree | 39fefe6a4e2f97a78e402e915091a3c6ae0e2afd | |
| parent | 2bd9eb83b4863768203460aa1aa643f02e1501ab (diff) | |
radv: do not emit rbplus if attachments are undefined
Fixes some crashes with dEQP-VK.geometry.layered.*.secondary_cmd_buffer
on Raven and other chips that allow rbplus.
This just prevents a crash and rbplus probaby needs more work.
Cc: 19.2 <[email protected]>
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
(cherry picked from commit 956d825ed845dd239b7098eccd5f5a7b4fecad9c)
| -rw-r--r-- | src/amd/vulkan/radv_cmd_buffer.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index c7c4e2e66f3..cdb63ad70a4 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -998,6 +998,9 @@ radv_emit_rbplus_state(struct radv_cmd_buffer *cmd_buffer) unsigned sx_blend_opt_epsilon = 0; unsigned sx_blend_opt_control = 0; + if (!cmd_buffer->state.attachments || !subpass) + return; + for (unsigned i = 0; i < subpass->color_count; ++i) { if (subpass->color_attachments[i].attachment == VK_ATTACHMENT_UNUSED) { sx_blend_opt_control |= S_02875C_MRT0_COLOR_OPT_DISABLE(1) << (i * 4); |