summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVlad Golovkin <[email protected]>2018-08-01 20:56:23 +0300
committerEric Engestrom <[email protected]>2018-08-02 11:13:40 +0100
commit9d3a2394e4d3f91f1e23a971ce34aaf031a1e777 (patch)
tree7c9080604890bc44b34c691bb3a3052f5e1ed1d8
parent8d3ccdbb9ba480dfe435023b747714cd517e5028 (diff)
swr: Remove unnecessary memset call
Zeroing memory after calloc is not necessary. This also allows to avoid possible crash when allocation fails, because memset is called before checking screen for NULL. Fixes: a29d63ecf71546c4798c6 "swr: refactor swr_create_screen to allow for proper cleanup on error" Reviewed-by: Eric Engestrom <[email protected]>
-rw-r--r--src/gallium/drivers/swr/swr_screen.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp
index fa232b6838b..67085444f84 100644
--- a/src/gallium/drivers/swr/swr_screen.cpp
+++ b/src/gallium/drivers/swr/swr_screen.cpp
@@ -1148,7 +1148,6 @@ struct pipe_screen *
swr_create_screen_internal(struct sw_winsys *winsys)
{
struct swr_screen *screen = CALLOC_STRUCT(swr_screen);
- memset(screen, 0, sizeof(struct swr_screen));
if (!screen)
return NULL;