diff options
| author | Matt Whitlock <[email protected]> | 2016-10-01 23:49:41 -0400 |
|---|---|---|
| committer | Nicolai Hähnle <[email protected]> | 2016-10-04 11:08:50 +0200 |
| commit | c8fd7d060d000a89f08f690ec72349ab97ae41bc (patch) | |
| tree | 50507cba18336a0353ba4a4d704c14821476ff6c | |
| parent | 387e0af0b42fefb462a60068fcbdef77236129a0 (diff) | |
egl/android: replace call to dup(2) with fcntl(F_DUPFD_CLOEXEC)
Without this fix, duplicated file descriptors leak into child processes.
See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance
where the same fix was employed.
Cc: <[email protected]>
Signed-off-by: Matt Whitlock <[email protected]>
Reviewed-by: Nicolai Hähnle <[email protected]>
| -rw-r--r-- | src/egl/drivers/dri2/platform_android.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 2e0df077f85..f86898401c6 100644 --- a/src/egl/drivers/dri2/platform_android.c +++ b/src/egl/drivers/dri2/platform_android.c @@ -29,6 +29,7 @@ #include <errno.h> #include <dlfcn.h> +#include <fcntl.h> #include <xf86drm.h> #if ANDROID_VERSION >= 0x402 @@ -830,7 +831,7 @@ droid_open_device(void) fd = -1; } - return (fd >= 0) ? dup(fd) : -1; + return (fd >= 0) ? fcntl(fd, F_DUPFD_CLOEXEC, 3) : -1; } /* support versions < JellyBean */ |