diff options
| author | Caio Marcelo de Oliveira Filho <[email protected]> | 2018-07-16 13:40:26 -0700 |
|---|---|---|
| committer | Caio Marcelo de Oliveira Filho <[email protected]> | 2018-07-18 08:29:51 -0700 |
| commit | df8f1637fa08dcf876840a315a5b8461a6ce890a (patch) | |
| tree | 460181a7bd5e5fb438b32a8a8c7a555dc23f7b0c | |
| parent | 4a29ee186195ab38a81280cefb6a476e3763da11 (diff) | |
glsl: remove unnecessary parenthesis from macro
The "__inst" will contain the name used for the variable of type
"__type *". Parenthesis is not necessary as the name itself shouldn't
be an expression.
Fixes warning:
In file included from ../../src/mesa/main/mtypes.h:49,
from ../../src/intel/compiler/brw_compiler.h:30,
from ../../src/intel/compiler/brw_shader.h:29,
from ../../src/intel/compiler/brw_fs.h:31,
from ../../src/intel/compiler/brw_fs_cse.cpp:24:
../../src/intel/compiler/brw_fs_cse.cpp: In member function ‘bool fs_visitor::opt_cse_local(bblock_t*)’:
../../src/compiler/glsl/list.h:675:12: warning: unnecessary parentheses in declaration of ‘entry’ [-Wparentheses]
__type *(__inst); \
^
../../src/intel/compiler/brw_fs_cse.cpp:257:10: note: in expansion of macro ‘foreach_in_list_use_after’
foreach_in_list_use_after(aeb_entry, entry, &aeb) {
^~~~~~~~~~~~~~~~~~~~~~~~~
Reviewed-by: Anuj Phogat <[email protected]>
| -rw-r--r-- | src/compiler/glsl/list.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/compiler/glsl/list.h b/src/compiler/glsl/list.h index 2bfa2735544..59ed766f2e1 100644 --- a/src/compiler/glsl/list.h +++ b/src/compiler/glsl/list.h @@ -672,7 +672,7 @@ inline void exec_node::insert_before(exec_list *before) __node = __prev, __prev = (__type *)__prev->prev) #define foreach_in_list_use_after(__type, __inst, __list) \ - __type *(__inst); \ + __type *__inst; \ for ((__inst) = (__type *)(__list)->head_sentinel.next; \ !(__inst)->is_tail_sentinel(); \ (__inst) = (__type *)(__inst)->next) |