diff options
author | Brian Paul <[email protected]> | 2008-12-09 14:30:42 -0700 |
---|---|---|
committer | Brian Paul <[email protected]> | 2008-12-15 18:19:05 -0700 |
commit | 63fc119d6c4f300958768144bd2a944e61c33eeb (patch) | |
tree | b72114e251a4e0a3208495f470a06a0f04424919 | |
parent | b8bfddf976682d8c466994942bf539619511c594 (diff) |
mesa: in slang linker, replace assertion with link error when max samplers exceeded
-rw-r--r-- | src/mesa/shader/slang/slang_link.c | 24 |
1 files changed, 18 insertions, 6 deletions
diff --git a/src/mesa/shader/slang/slang_link.c b/src/mesa/shader/slang/slang_link.c index 08d75403723..834f05176c4 100644 --- a/src/mesa/shader/slang/slang_link.c +++ b/src/mesa/shader/slang/slang_link.c @@ -207,7 +207,7 @@ link_varying_vars(struct gl_shader_program *shProg, struct gl_program *prog) * This is basically a list/index of all uniforms found in either/both of * the vertex and fragment shaders. */ -static void +static GLboolean link_uniform_vars(struct gl_shader_program *shProg, struct gl_program *prog, GLuint *numSamplers) @@ -239,7 +239,10 @@ link_uniform_vars(struct gl_shader_program *shProg, /* Allocate a new sampler index */ GLuint sampNum = *numSamplers; GLuint oldSampNum = (GLuint) prog->Parameters->ParameterValues[i][0]; - assert(oldSampNum < MAX_SAMPLERS); + if (oldSampNum >= MAX_SAMPLERS) { + link_error(shProg, "Too many texture samplers"); + return GL_FALSE; + } samplerMap[oldSampNum] = sampNum; (*numSamplers)++; } @@ -265,6 +268,7 @@ link_uniform_vars(struct gl_shader_program *shProg, } } + return GL_TRUE; } @@ -560,10 +564,18 @@ _slang_link(GLcontext *ctx, } /* link uniform vars */ - if (shProg->VertexProgram) - link_uniform_vars(shProg, &shProg->VertexProgram->Base, &numSamplers); - if (shProg->FragmentProgram) - link_uniform_vars(shProg, &shProg->FragmentProgram->Base, &numSamplers); + if (shProg->VertexProgram) { + if (!link_uniform_vars(shProg, &shProg->VertexProgram->Base, + &numSamplers)) { + return; + } + } + if (shProg->FragmentProgram) { + if (!link_uniform_vars(shProg, &shProg->FragmentProgram->Base, + &numSamplers)) { + return; + } + } /*_mesa_print_uniforms(shProg->Uniforms);*/ |