diff options
| author | Timothy Arceri <[email protected]> | 2017-04-08 10:26:34 +1000 |
|---|---|---|
| committer | Timothy Arceri <[email protected]> | 2017-04-10 10:55:34 +1000 |
| commit | 1b85009ec14ded1b51e3ceafc748b8f5ee732874 (patch) | |
| tree | 1d5d801bda4fc8c8ea7314cbf3eff43acea73d38 | |
| parent | 3387f66cab058d5e3bfa5fee5d8a9ea5c8ce9568 (diff) | |
nouveau: take ownership rather than adding reference for new renderbuffers
This avoids locking in the reference calls and fixes a leak after the
RefCount initialisation was change from 0 to 1.
Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation)
Reviewed-by: Emil Velikov <[email protected]>
| -rw-r--r-- | src/mesa/drivers/dri/nouveau/nouveau_screen.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/mesa/drivers/dri/nouveau/nouveau_screen.c b/src/mesa/drivers/dri/nouveau/nouveau_screen.c index 1f4cbe8a61d..2dbd9d13b67 100644 --- a/src/mesa/drivers/dri/nouveau/nouveau_screen.c +++ b/src/mesa/drivers/dri/nouveau/nouveau_screen.c @@ -259,27 +259,27 @@ nouveau_create_buffer(__DRIscreen *dri_screen, /* Front buffer. */ rb = nouveau_renderbuffer_dri_new(color_format, drawable); - _mesa_add_renderbuffer(fb, BUFFER_FRONT_LEFT, rb); + _mesa_add_renderbuffer_without_ref(fb, BUFFER_FRONT_LEFT, rb); /* Back buffer */ if (visual->doubleBufferMode) { rb = nouveau_renderbuffer_dri_new(color_format, drawable); - _mesa_add_renderbuffer(fb, BUFFER_BACK_LEFT, rb); + _mesa_add_renderbuffer_without_ref(fb, BUFFER_BACK_LEFT, rb); } /* Depth/stencil buffer. */ if (visual->depthBits == 24 && visual->stencilBits == 8) { rb = nouveau_renderbuffer_dri_new(GL_DEPTH24_STENCIL8_EXT, drawable); - _mesa_add_renderbuffer(fb, BUFFER_DEPTH, rb); + _mesa_add_renderbuffer_without_ref(fb, BUFFER_DEPTH, rb); _mesa_add_renderbuffer(fb, BUFFER_STENCIL, rb); } else if (visual->depthBits == 24) { rb = nouveau_renderbuffer_dri_new(GL_DEPTH_COMPONENT24, drawable); - _mesa_add_renderbuffer(fb, BUFFER_DEPTH, rb); + _mesa_add_renderbuffer_without_ref(fb, BUFFER_DEPTH, rb); } else if (visual->depthBits == 16) { rb = nouveau_renderbuffer_dri_new(GL_DEPTH_COMPONENT16, drawable); - _mesa_add_renderbuffer(fb, BUFFER_DEPTH, rb); + _mesa_add_renderbuffer_without_ref(fb, BUFFER_DEPTH, rb); } /* Software renderbuffers. */ |