diff options
| author | Christian Gmeiner <[email protected]> | 2017-01-31 09:10:27 +0100 |
|---|---|---|
| committer | Christian Gmeiner <[email protected]> | 2017-01-31 09:19:25 +0100 |
| commit | 82fe240a9912d78bc2eec513c1139c918c5f189f (patch) | |
| tree | 7b94432dee271b4d0f25df333812062f3582c7b7 | |
| parent | 8477aa71d902d6a6fd89741151f8d119a72a7dc0 (diff) | |
etnaviv: Avoid infinite loop in find_frame()
Use of unsigned loop control variable with '>= 0' would lead
to infinite loop.
Reported by clang:
etnaviv_compiler.c:1024:39: warning: comparison of unsigned expression
>= 0 is always true [-Wtautological-compare]
for (unsigned sp = c->frame_sp; sp >= 0; sp--)
~~ ^ ~
v2: Simply use the same datatype as c->frame_sp is using.
CC: <[email protected]>
Reported-by: Rhys Kidd <[email protected]>
Signed-off-by: Christian Gmeiner <[email protected]>
Reviewed-by: Rhys Kidd <[email protected]>
| -rw-r--r-- | src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c index 59e1452d801..dc9af57bcf2 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_compiler.c +++ b/src/gallium/drivers/etnaviv/etnaviv_compiler.c @@ -1021,7 +1021,7 @@ label_mark_use(struct etna_compile *c, struct etna_compile_label *label) static struct etna_compile_frame * find_frame(struct etna_compile *c, enum etna_compile_frame_type type) { - for (unsigned sp = c->frame_sp; sp >= 0; sp--) + for (int sp = c->frame_sp; sp >= 0; sp--) if (c->frame_stack[sp].type == type) return &c->frame_stack[sp]; |