diff options
author | Corbin Simpson <[email protected]> | 2010-04-02 14:21:50 -0700 |
---|---|---|
committer | Corbin Simpson <[email protected]> | 2010-04-02 14:21:50 -0700 |
commit | 21961f6e9614f234be704da93032cb4ec197eef4 (patch) | |
tree | 547bab0c668c65b65385018da7eea40420272ff0 | |
parent | f6c7b911653fb1508256c63518ef0bd15d68186e (diff) |
r300g: Expound on dithering comment.
-rw-r--r-- | src/gallium/drivers/r300/r300_state.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/src/gallium/drivers/r300/r300_state.c b/src/gallium/drivers/r300/r300_state.c index bf17d5d9203..2c0a7d82f5b 100644 --- a/src/gallium/drivers/r300/r300_state.c +++ b/src/gallium/drivers/r300/r300_state.c @@ -320,12 +320,17 @@ static void* r300_create_blend_state(struct pipe_context* pipe, } } + /* Neither fglrx nor classic r300 ever set this, regardless of dithering + * state. Since it's an optional implementation detail, we can leave it + * out and never dither. + * + * This could be revisited if we ever get quality or conformance hints. + * if (state->dither) { - /* fglrx appears to never set this */ - blend->dither = 0; - /* blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT | - R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT; */ + blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT | + R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT; } + */ return (void*)blend; } |