diff options
| author | Samuel Pitoiset <[email protected]> | 2019-06-06 14:46:47 +0200 |
|---|---|---|
| committer | Samuel Pitoiset <[email protected]> | 2019-06-10 17:21:56 +0200 |
| commit | e9316fdfd4899c269a19e106a6ffa4309ae48b27 (patch) | |
| tree | 5039911ef8ee0715db55d0e590aa05b83a9c7fb7 | |
| parent | 50ffaaff3b1fbd43688747ad2c50da97334d8808 (diff) | |
radv: fix setting CB_SHADER_MASK for dual source blending
CB_SHADER_MASK was computed without the second color buffer
format which looks totally wrong to me.
While we are at it, copy a comment from RadeonSI.
Cc: 19.0 19.1 <[email protected]>
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-By: Bas Nieuwenhuizen <[email protected]>
| -rw-r--r-- | src/amd/vulkan/radv_pipeline.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 6c0d0994cdb..8bc0d9b53e6 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -541,10 +541,13 @@ radv_pipeline_compute_spi_color_formats(struct radv_pipeline *pipeline, } } - blend->cb_shader_mask = ac_get_cb_shader_mask(col_format); - + /* The output for dual source blending should have the same format as + * the first output. + */ if (blend->mrt0_is_dual_src) col_format |= (col_format & 0xf) << 4; + + blend->cb_shader_mask = ac_get_cb_shader_mask(col_format); blend->spi_shader_col_format = col_format; } |