summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2018-10-18 21:15:02 -0700
committerKenneth Graunke <[email protected]>2019-02-21 10:26:09 -0800
commit973b937cac02a17b8fd23d69cdecda7579973bcb (patch)
tree524a649c8c3170d83be04f59b3523d0b61a06a50
parent7fb8c20d7bef5df4a194aaa5385e1efc80c83270 (diff)
iris: leave XXX about unnecessary binding table uploads
-rw-r--r--src/gallium/drivers/iris/iris_state.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c
index 0a1127440f1..f36838262e5 100644
--- a/src/gallium/drivers/iris/iris_state.c
+++ b/src/gallium/drivers/iris/iris_state.c
@@ -4309,6 +4309,8 @@ iris_upload_compute_state(struct iris_context *ice,
.stride_B = 1,
.mocs = MOCS_WB);
+ // XXX: this will update the binding table on every dispatch, should
+ // XXX: check if the grid size actually changed (or indirect buf changed)
if (dirty & IRIS_DIRTY_BINDINGS_CS || grid_size_res)
iris_populate_binding_table(ice, batch, MESA_SHADER_COMPUTE, false,
&grid_size_surf);