diff options
author | Kenneth Graunke <[email protected]> | 2018-11-10 00:08:03 -0800 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2019-02-21 10:26:10 -0800 |
commit | 89833eddab9354da5e70fe695159f6860cbb4cd5 (patch) | |
tree | b7fbb0ef221731247283d20c70179b39c0ed190b | |
parent | 983e2ae7d297cb07c29c361efffea8b634783048 (diff) |
iris: leave another TODO
-rw-r--r-- | src/gallium/drivers/iris/iris_batch.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/gallium/drivers/iris/iris_batch.c b/src/gallium/drivers/iris/iris_batch.c index 203ca139f66..1d3a787d365 100644 --- a/src/gallium/drivers/iris/iris_batch.c +++ b/src/gallium/drivers/iris/iris_batch.c @@ -215,6 +215,9 @@ add_exec_bo(struct iris_batch *batch, struct iris_bo *bo) * those first. */ for (int b = 0; b < ARRAY_SIZE(batch->other_batches); b++) { + // XXX: this is bad, we use the same state / instruction buffers for + // both batches, and if both of them are reading some dynamic state, + // we flush all the time. check for writes vs. reads? if (iris_batch_references(batch->other_batches[b], bo)) iris_batch_flush(batch->other_batches[b]); } |