diff options
| author | Caio Marcelo de Oliveira Filho <[email protected]> | 2019-11-08 15:58:15 -0800 |
|---|---|---|
| committer | Caio Marcelo de Oliveira Filho <[email protected]> | 2019-11-08 16:28:21 -0800 |
| commit | 087ecd9ca58a84cf85e66323b44140e7304d5f93 (patch) | |
| tree | 0af448b2f2b941c1dc51dcd6899262333bbaf276 | |
| parent | 84a1a2578dab10ddb7ada831b598db5f7bc6a859 (diff) | |
spirv: Don't leak GS initialization to other stages
The stage specific fields of shader_info are in an union. We've
likely been lucky that this value was either overwritten or ignored by
other stages. The recent change in shader_info layout in commit
84a1a2578da ("compiler: pack shader_info from 160 bytes to 96 bytes")
made this issue visible.
Fixes: cf2257069cb ("nir/spirv: Set a default number of invocations for geometry shaders")
Reviewed-by: Jason Ekstrand <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
| -rw-r--r-- | src/compiler/spirv/spirv_to_nir.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 4c1da666261..eeca640ba49 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -5152,7 +5152,8 @@ spirv_to_nir(const uint32_t *words, size_t word_count, } /* Set shader info defaults */ - b->shader->info.gs.invocations = 1; + if (stage == MESA_SHADER_GEOMETRY) + b->shader->info.gs.invocations = 1; /* Parse rounding mode execution modes. This has to happen earlier than * other changes in the execution modes since they can affect, for example, |