summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Ekstrand <[email protected]>2018-08-30 12:50:31 -0500
committerJason Ekstrand <[email protected]>2018-08-30 14:06:31 -0500
commita0f18f214215931bfe6b27dd86c09ec5bae49103 (patch)
treea1a2111b564721982817575162c7af9dd8893fa9
parentd9cf4308ceea3762c1aab48f9c48e12a72162b5a (diff)
intel/nir: Lowering image loads and stores trashes all metadata
This fixes the GL_ARB_fragment_shader_interlock piglit test on gen8 platforms where the lack of metadata dirtying was causing another pass to accidentally delete a much needed loop. https://bugs.freedesktop.org/show_bug.cgi?id=107745 Fixes: 37f7983bcca1 "intel/compiler: Do image load/store lowering..." Jason Ekstrand <[email protected]> writes: Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]>
-rw-r--r--src/intel/compiler/brw_nir_lower_image_load_store.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/intel/compiler/brw_nir_lower_image_load_store.c b/src/intel/compiler/brw_nir_lower_image_load_store.c
index de6f7683be4..e8083a80cb7 100644
--- a/src/intel/compiler/brw_nir_lower_image_load_store.c
+++ b/src/intel/compiler/brw_nir_lower_image_load_store.c
@@ -817,8 +817,8 @@ brw_nir_lower_image_load_store(nir_shader *shader,
}
}
- nir_metadata_preserve(function->impl, nir_metadata_block_index |
- nir_metadata_dominance);
+ if (progress)
+ nir_metadata_preserve(function->impl, nir_metadata_none);
}
return progress;