diff options
| author | Kenneth Graunke <[email protected]> | 2017-10-10 10:19:21 -0700 |
|---|---|---|
| committer | Kenneth Graunke <[email protected]> | 2017-10-11 12:22:29 -0700 |
| commit | fe7fab4be55983fa8abc0172393afea8b0fed416 (patch) | |
| tree | 860f9befbe2dac6144581bbf91d163463c91d922 | |
| parent | e401cfa28a6e32d7081f9de998e731965ce966fb (diff) | |
i965: Drop brw_bo_alloc in ARB_indirect_parameters implementation.
The original implementation allocated a new BO here, but we decided to
switch to intel_upload_space, which returns a reference to the current
upload BO. We accidentally kept the brw_bo_alloc, even though it's no
longer necessary - intel_upload_space will immediately unreference it,
causing us to allocate and immediately free a buffer.
Reviewed-by: Plamena Manolova <[email protected]>
| -rw-r--r-- | src/mesa/drivers/dri/i965/brw_draw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index d6aa95b6f60..0364d442f21 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++ b/src/mesa/drivers/dri/i965/brw_draw.c @@ -903,7 +903,7 @@ brw_draw_prims(struct gl_context *ctx, for (i = 0; i < nr_prims; i++) { /* Implementation of ARB_indirect_parameters via predicates */ if (brw->draw.draw_params_count_bo) { - struct brw_bo *draw_id_bo = brw_bo_alloc(brw->bufmgr, "draw_id", 4, 4); + struct brw_bo *draw_id_bo = NULL; uint32_t draw_id_offset; intel_upload_data(brw, &prims[i].draw_id, 4, 4, &draw_id_bo, |