diff options
author | Chad Versace <[email protected]> | 2016-01-14 12:58:46 -0800 |
---|---|---|
committer | Chad Versace <[email protected]> | 2016-01-14 13:14:40 -0800 |
commit | ea20389320b251f6498eb9c47e525ced10aab91d (patch) | |
tree | 63099bb0343c424734e2a9b6ee984a7ae8a678ae | |
parent | 20fd816b6bb6dbd64abd953f2958b3c9ff6ddf07 (diff) |
anv: Add FIXME for vkResetCommandPool
vkResetCommandPool currently destroys its command buffers. The Vulkan
1.0 spec requires that it only reset them:
Resetting a command pool recycles all of the resources from all of
the command buffers allocated from the command pool back to the
command pool. All command buffers that have been allocated from the
command pool are put in the initial state.
-rw-r--r-- | src/vulkan/anv_cmd_buffer.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/vulkan/anv_cmd_buffer.c b/src/vulkan/anv_cmd_buffer.c index 8cf4dc7202c..a888a542751 100644 --- a/src/vulkan/anv_cmd_buffer.c +++ b/src/vulkan/anv_cmd_buffer.c @@ -1074,6 +1074,14 @@ VkResult anv_ResetCommandPool( { ANV_FROM_HANDLE(anv_cmd_pool, pool, commandPool); + /* FIXME: vkResetCommandPool must not destroy its command buffers. The + * Vulkan 1.0 spec requires that it only reset them: + * + * Resetting a command pool recycles all of the resources from all of + * the command buffers allocated from the command pool back to the + * command pool. All command buffers that have been allocated from the + * command pool are put in the initial state. + */ list_for_each_entry_safe(struct anv_cmd_buffer, cmd_buffer, &pool->cmd_buffers, pool_link) { anv_cmd_buffer_destroy(cmd_buffer); |