diff options
| author | Nicolai Hähnle <[email protected]> | 2016-05-13 01:56:44 -0500 |
|---|---|---|
| committer | Nicolai Hähnle <[email protected]> | 2016-06-15 09:27:40 +0200 |
| commit | 494e4b8976a48e37e3cb51338ad69e085ea5061a (patch) | |
| tree | 58a2f034ddfa87d0d0250bd960b508d0e4200060 | |
| parent | 6510e0734563ff8d30e45b8781153367db15cc5b (diff) | |
st_glsl_to_tgsi: don't read potentially uninitialized buffer variable
Found by -fsanitize=undefined. Note that this should be a harmless issue in
practice because the inst->op check always dominates anyway.
Reviewed-by: Brian Paul <[email protected]>
Reviewed-by: Ilia Mirkin <[email protected]>
| -rw-r--r-- | src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index b7eaa13ffb2..8c6fe79d832 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp @@ -3334,7 +3334,7 @@ glsl_to_tgsi_visitor::visit_ssbo_intrinsic(ir_call *ir) inst = (glsl_to_tgsi_instruction *)inst->get_prev(); if (inst->op == TGSI_OPCODE_UADD) inst = (glsl_to_tgsi_instruction *)inst->get_prev(); - } while (inst && inst->buffer.file == PROGRAM_UNDEFINED && inst->op == op); + } while (inst && inst->op == op && inst->buffer.file == PROGRAM_UNDEFINED); } void |