summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Pitoiset <[email protected]>2018-09-17 11:20:57 +0200
committerSamuel Pitoiset <[email protected]>2018-09-17 11:20:57 +0200
commit6521d4a659b911bb86d979564de03665616a671e (patch)
treec6d6f429781d7902a9ce842446573649186f6a71
parent90819abb56f6b1a0cd4946b13b6caf24fb46e500 (diff)
Revert "radv: Optimize rebinding the same descriptor set."
This introduces random GPU hangs on Vega, at least. This reverts commit 02a43edf186cb9998741ba765cb948bb238a122d.
-rw-r--r--src/amd/vulkan/radv_cmd_buffer.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 2f168321197..d492456d6b8 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2464,13 +2464,7 @@ void radv_CmdBindDescriptorSets(
for (unsigned i = 0; i < descriptorSetCount; ++i) {
unsigned idx = i + firstSet;
RADV_FROM_HANDLE(radv_descriptor_set, set, pDescriptorSets[i]);
-
- /* If the set is already bound we only need to update the
- * (potentially changed) dynamic offsets. */
- if (descriptors_state->sets[idx] != set ||
- !(descriptors_state->valid & (1u << idx))) {
- radv_bind_descriptor_set(cmd_buffer, pipelineBindPoint, set, idx);
- }
+ radv_bind_descriptor_set(cmd_buffer, pipelineBindPoint, set, idx);
for(unsigned j = 0; j < set->layout->dynamic_offset_count; ++j, ++dyn_idx) {
unsigned idx = j + layout->set[i + firstSet].dynamic_offset_start;