diff options
| author | Kenneth Graunke <[email protected]> | 2019-06-28 10:11:01 -0700 |
|---|---|---|
| committer | Kenneth Graunke <[email protected]> | 2019-07-22 16:58:09 -0700 |
| commit | fc21394bc4d4e5c3ec06675bbb26974e5550c385 (patch) | |
| tree | 808ced340066a5cee25abd5716036e6175fceaa7 | |
| parent | 78164a3a6c278adcbb93e21b64a575c3f8598327 (diff) | |
egl: Quiet warning about front buffer rendering for pixmaps/pbuffers
pbuffer configs cause a million of these warnings to trigger, but
when using pixmaps or buffers, there is only one surface, so this
warning doesn't make much sense. Retain it for window surfaces for now.
Fixes: dacb11a585f ("egl: Add a 565 pbuffer-only EGL config under X11.")
Reviewed-by: Eric Engestrom <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
| -rw-r--r-- | src/egl/drivers/dri2/platform_x11_dri3.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/egl/drivers/dri2/platform_x11_dri3.c b/src/egl/drivers/dri2/platform_x11_dri3.c index adcc884c5c2..c2228b08b00 100644 --- a/src/egl/drivers/dri2/platform_x11_dri3.c +++ b/src/egl/drivers/dri2/platform_x11_dri3.c @@ -403,13 +403,15 @@ dri3_create_image_khr(_EGLDriver *drv, _EGLDisplay *disp, static void dri3_flush_front_buffer(__DRIdrawable *driDrawable, void *loaderPrivate) { + struct loader_dri3_drawable *draw = loaderPrivate; + (void) driDrawable; + /* There does not seem to be any kind of consensus on whether we should * support front-buffer rendering or not: * http://lists.freedesktop.org/archives/mesa-dev/2013-June/040129.html */ - _eglLog(_EGL_WARNING, "FIXME: egl/x11 doesn't support front buffer rendering."); - (void) driDrawable; - (void) loaderPrivate; + if (!draw->is_pixmap) + _eglLog(_EGL_WARNING, "FIXME: egl/x11 doesn't support front buffer rendering."); } const __DRIimageLoaderExtension dri3_image_loader_extension = { |