diff options
| author | Paulo Zanoni <[email protected]> | 2019-11-01 14:28:48 -0700 |
|---|---|---|
| committer | Paulo Zanoni <[email protected]> | 2019-11-05 00:08:34 +0000 |
| commit | b57383a9445eae153fbf91fad8592d273b14e546 (patch) | |
| tree | 5586dd78db1b91962bfa9303fa96e05c36b9fd0a | |
| parent | 4319cc8c0f51a9e103167b35c02d9460a9840170 (diff) | |
intel/compiler: remove the operand restriction for src1 on GLK
Commit 5847de6e9afe implemented a restriction that applies to ICL, but
wrongly marked it as also applying to GLK. Reviewers or MR !1125
pointed this, and the commit history shows removal of GLK to parts of
the patch, but it turns there was still a left-over GLK check in the
code.
This code was breaking some of the i8vec2 tests on GLK, for example:
dEQP-VK.subgroups.arithmetic.compute.subgroupadd_i8vec2
Removing the GLK check solves the issue for GLK. I don't see a reason
on why implementing this restriction would actually break GLK, so
there's still more to investigate here since this bug may be affecting
ICL+, but let's apply the real GLK fix while we analyze and discuss
the other possible issues.
Fixes: 5847de6e9afe ("intel/compiler: don't use byte operands for src1
on ICL")
BSpec: 3017
Reviewed-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Matt Turner <[email protected]>
Signed-off-by: Paulo Zanoni <[email protected]>
| -rw-r--r-- | src/intel/compiler/brw_fs_builder.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/intel/compiler/brw_fs_builder.h b/src/intel/compiler/brw_fs_builder.h index 54f5bd16892..fef3dd01b5b 100644 --- a/src/intel/compiler/brw_fs_builder.h +++ b/src/intel/compiler/brw_fs_builder.h @@ -736,8 +736,7 @@ namespace brw { src_reg fix_byte_src(const src_reg &src) const { - if ((shader->devinfo->gen < 11 && !shader->devinfo->is_geminilake) || - type_sz(src.type) != 1) + if (shader->devinfo->gen < 11 || type_sz(src.type) != 1) return src; dst_reg temp = vgrf(src.type == BRW_REGISTER_TYPE_UB ? |