aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Anholt <[email protected]>2019-11-11 15:52:53 -0800
committerMarge Bot <[email protected]>2020-02-04 19:02:59 +0000
commit8a2c507a8abe2537df5bc1f4847c40e6d4314dec (patch)
treed05c7ff835d5487e9c0cf43eb8869fcb75e5a03c
parent1d367c3aa57da54f5dbd6871a38b9fc1d6cbcc45 (diff)
util: Drop unpacking from int signed to unsigned and vice versa.
After all the previous cleanups, it's clear that the callers only ever ask for SINT->SINT or UINT->UINT. Cuts 20k of compiled text from gallium drivers. Reviewed-by: Marek Olšák <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
-rw-r--r--src/util/format/u_format_pack.py2
-rw-r--r--src/util/format/u_format_table.py4
2 files changed, 2 insertions, 4 deletions
diff --git a/src/util/format/u_format_pack.py b/src/util/format/u_format_pack.py
index 0653e5e4a9e..5a1763d1e6f 100644
--- a/src/util/format/u_format_pack.py
+++ b/src/util/format/u_format_pack.py
@@ -727,7 +727,6 @@ def generate(formats):
channel = Channel(SIGNED, False, True, 32)
native_type = 'int'
suffix = 'signed'
- generate_format_unpack(format, channel, native_type, suffix)
generate_format_pack(format, channel, native_type, suffix)
elif format.is_pure_signed():
native_type = 'int'
@@ -741,7 +740,6 @@ def generate(formats):
native_type = 'unsigned'
suffix = 'unsigned'
channel = Channel(UNSIGNED, False, True, 32)
- generate_format_unpack(format, channel, native_type, suffix)
generate_format_pack(format, channel, native_type, suffix)
else:
channel = Channel(FLOAT, False, False, 32)
diff --git a/src/util/format/u_format_table.py b/src/util/format/u_format_table.py
index 2bc82c36f42..336de4b31b4 100644
--- a/src/util/format/u_format_table.py
+++ b/src/util/format/u_format_table.py
@@ -182,12 +182,12 @@ def write_format_table(formats):
if format.is_pure_unsigned():
print(" &util_format_%s_unpack_unsigned, /* unpack_rgba_uint */" % format.short_name())
print(" &util_format_%s_pack_unsigned, /* pack_rgba_uint */" % format.short_name())
- print(" &util_format_%s_unpack_signed, /* unpack_rgba_sint */" % format.short_name())
+ print(" NULL, /* unpack_rgba_sint */")
print(" &util_format_%s_pack_signed, /* pack_rgba_sint */" % format.short_name())
print(" &util_format_%s_fetch_unsigned, /* fetch_rgba_uint */" % format.short_name())
print(" NULL /* fetch_rgba_sint */")
elif format.is_pure_signed():
- print(" &util_format_%s_unpack_unsigned, /* unpack_rgba_uint */" % format.short_name())
+ print(" NULL, /* unpack_rgba_uint */")
print(" &util_format_%s_pack_unsigned, /* pack_rgba_uint */" % format.short_name())
print(" &util_format_%s_unpack_signed, /* unpack_rgba_sint */" % format.short_name())
print(" &util_format_%s_pack_signed, /* pack_rgba_sint */" % format.short_name())