diff options
| author | Chris Wilson <[email protected]> | 2015-10-02 10:39:39 -0700 |
|---|---|---|
| committer | Kenneth Graunke <[email protected]> | 2015-10-02 10:44:28 -0700 |
| commit | 6b7036498a9eed99c7f726d406d4638f97ddf0af (patch) | |
| tree | 7c02b74073ad1388423e986ab636528df350eb0c | |
| parent | 33da78adeef0f0d71c70ac63c53ab70d6e7ebdc2 (diff) | |
nir: Fix uninitialized 'progress' variable in nir_lower_system_values.
Commit 0a1adaf11d051b71b4c46aabee2e5342f2d6aef3 (nir: Report progress
from nir_lower_system_values().) introduced a bug caught by Valgrind:
==823== Conditional jump or move depends on uninitialised value(s)
==823== at 0xB09020C: convert_block (nir_lower_system_values.c:68)
==823== by 0xB079FB8: foreach_cf_node (nir.c:1310)
==823== by 0xB07A0AF: nir_foreach_block (nir.c:1336)
==823== by 0xB09026B: convert_impl (nir_lower_system_values.c:79)
...
==823== Uninitialised value was created by a stack allocation
==823== at 0xB090249: convert_impl (nir_lower_system_values.c:76)
which is trivially fixed by initializing progress.
Reviewed-by: Kenneth Graunke <[email protected]>
| -rw-r--r-- | src/glsl/nir/nir_lower_system_values.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/glsl/nir/nir_lower_system_values.c b/src/glsl/nir/nir_lower_system_values.c index d77bb2f8213..21904f81b97 100644 --- a/src/glsl/nir/nir_lower_system_values.c +++ b/src/glsl/nir/nir_lower_system_values.c @@ -74,7 +74,7 @@ convert_block(nir_block *block, void *state) static bool convert_impl(nir_function_impl *impl) { - bool progress; + bool progress = false; nir_foreach_block(impl, convert_block, &progress); nir_metadata_preserve(impl, nir_metadata_block_index | |