diff options
| author | Adam Jackson <[email protected]> | 2020-01-06 11:06:30 -0500 |
|---|---|---|
| committer | Marge Bot <[email protected]> | 2020-01-23 23:03:13 +0000 |
| commit | 2fc11e8a05f59bbffed284c86108fedbac315081 (patch) | |
| tree | 41f80d7cb90d41ef059f58d64ee182ff2a420b5a /.gitlab-ci | |
| parent | 59f29fc845ce6425959e8db9b707363b1e273445 (diff) | |
drisw: Cache the depth of the X drawable
This is not always ->rgbBits, because there are cases where that could
be 32 but we're (legally) bound to a depth-24 pixmap. The important
thing to have match here is the actual server-side notion of depth. You
can look this up (at modest expense) from the xlib visual info if the
fbconfig has a visual. But it might not, so if not, fetch it (at
slightly greater expense) from XGetGeometry. Do this at GLX drawable
creation so you don't have to do it on the SwapBuffers path.
Apparently this fixes glx/glx-swap-singlebuffer, which is unintentional
but quite pleasant.
Fixes: mesa/mesa#2291
Fixes: 90d58286 ("drisw: Fix and simplify drawable setup")
Reviewed-by: Eric Anholt <[email protected]>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3305>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3305>
Diffstat (limited to '.gitlab-ci')
| -rw-r--r-- | .gitlab-ci/piglit/quick_gl.txt | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/.gitlab-ci/piglit/quick_gl.txt b/.gitlab-ci/piglit/quick_gl.txt index 51c2cbd68fe..586ec3c046d 100644 --- a/.gitlab-ci/piglit/quick_gl.txt +++ b/.gitlab-ci/piglit/quick_gl.txt @@ -22,7 +22,6 @@ glx/glx-swap-event_event: skip glx/glx-swap-event_interval: skip glx/glx-swap-exchange: skip glx/glx-swap-pixmap-bad: fail -glx/glx-swap-singlebuffer: fail glx/glx-visuals-depth: fail glx/glx-visuals-depth -pixmap: fail glx/glx-visuals-stencil: fail @@ -2206,8 +2205,8 @@ wgl/wgl-sanity: skip summary: name: results ---- -------- - pass: 19319 - fail: 235 + pass: 19320 + fail: 234 crash: 2 skip: 1948 timeout: 0 |