Changed usage of sprintf to snprintf. Made some small malloc'd buffers on the stack.

These changes are unlikely to change functionality, for if the buffer is too small to write to, something has already gone wrong. However, they are good as an additional safety guarantee, preventing memory from corruption in the case that something goes wrong.

1 files changed, 3 insertions, 3 deletions

diff --git a/plugin/icedteanp/IcedTeaNPPlugin.cc b/plugin/icedteanp/IcedTeaNPPlugin.cc
index 6f49726..657cf07 100644
--- a/plugin/icedteanp/IcedTeaNPPlugin.cc
+++ b/plugin/icedteanp/IcedTeaNPPlugin.cc
@@ -1227,9 +1227,9 @@ void consume_message(gchar* message) {
         {
 
           // clear the "instance X status" parts
-          sprintf(parts[0], "");
-          sprintf(parts[1], "");
-          sprintf(parts[2], "");
+          snprintf(parts[0], sizeof(""), "");
+          snprintf(parts[1], sizeof(""), "");
+          snprintf(parts[2], sizeof(""), "");
 
           // join the rest
           gchar* status_message = g_strjoinv(" ", parts);