diff options
| author | Adam Domurad <[email protected]> | 2012-05-17 14:14:03 -0400 |
|---|---|---|
| committer | Adam Domurad <[email protected]> | 2012-05-17 14:14:03 -0400 |
| commit | b42384fe344b0af2a54eb00735f7d59b6ba1ab6e (patch) | |
| tree | 1dc30db08c963ecdd9fbe5c7186a007f110b8057 /ChangeLog | |
| parent | 0c598ca6848b417c79245a971f26570d05144132 (diff) | |
Went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
@@ -1,3 +1,17 @@ +2012-05-17 Adam Domurad <[email protected]> + + Fixed uses of == to compare String objects to .equals where + appropriate. + Noted a non-obvious use of == to compare a 'magic' String reference. + * netx/net/sourceforge/jnlp/JNLPFile.java: + Changed calls that compare String contents from == to .equals + * plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java: + Same + * plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java: + Same + * netx/net/sourceforge/jnlp/Version.java: Added comment explaining why + == was used vs .equals + 2012-05-14 Jiri Vanek <[email protected]> * tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: |