Changed usage of sprintf to snprintf. Made some small malloc'd buffers on the stack.

These changes are unlikely to change functionality, for if the buffer is too small to write to, something has already gone wrong. However, they are good as an additional safety guarantee, preventing memory from corruption in the case that something goes wrong.

1 files changed, 12 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index dad6151..1e65d58 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2012-05-22  Adam Domurad  <[email protected]>
+
+        Changed allocation of small, fixed-size buffers to stack-based 
+        allocations. Changed occurences of sprintf to the safer function
+        snprintf, added buffer information. While unlikely to change
+        functionality, snprintf adds an extra check to prevent buffer
+        overflows.
+        * plugin/icedteanp/IcedTeaNPPlugin.cc: Allocation of small buffers 
+        using malloc changed to stack allocation & changed sprintf calls to 
+        buffer-size aware snprintf calls. 
+        * plugin/icedteanp/IcedTeaPluginUtils.cc: Same as above.
+
 2012-05-22  Jiri Vanek  <[email protected]>
 
 	* tests/jnlp_tests/signed/ReadPropertiesSigned/testcases/ReadPropertiesSignedTest.java: