From cecf821343290dbf5cdfa4f5d4c27d219f6460c0 Mon Sep 17 00:00:00 2001 From: Jack Lloyd Date: Sun, 6 Feb 2022 08:27:33 -0500 Subject: Fix clang-tidy readability-named-parameter --- src/lib/tls/credentials_manager.cpp | 32 ++++++++++++++++---------------- src/lib/tls/tls_callbacks.cpp | 8 ++++---- src/lib/tls/tls_cbc/tls_cbc.cpp | 2 +- src/lib/tls/tls_extensions.cpp | 4 ++-- src/lib/tls/tls_handshake_io.cpp | 4 ++-- 5 files changed, 25 insertions(+), 25 deletions(-) (limited to 'src/lib/tls') diff --git a/src/lib/tls/credentials_manager.cpp b/src/lib/tls/credentials_manager.cpp index aca751d00..dc349d160 100644 --- a/src/lib/tls/credentials_manager.cpp +++ b/src/lib/tls/credentials_manager.cpp @@ -10,21 +10,21 @@ namespace Botan { -std::string Credentials_Manager::psk_identity_hint(const std::string&, - const std::string&) +std::string Credentials_Manager::psk_identity_hint(const std::string& /*unused*/, + const std::string& /*unused*/) { return ""; } -std::string Credentials_Manager::psk_identity(const std::string&, - const std::string&, - const std::string&) +std::string Credentials_Manager::psk_identity(const std::string& /*unused*/, + const std::string& /*unused*/, + const std::string& /*unused*/) { return ""; } -SymmetricKey Credentials_Manager::psk(const std::string&, - const std::string&, +SymmetricKey Credentials_Manager::psk(const std::string& /*unused*/, + const std::string& /*unused*/, const std::string& identity) { throw Internal_Error("No PSK set for identity " + identity); @@ -32,7 +32,7 @@ SymmetricKey Credentials_Manager::psk(const std::string&, std::vector Credentials_Manager::find_cert_chain( const std::vector& key_types, - const std::vector&, + const std::vector& /*unused*/, const std::string& type, const std::string& context) { @@ -40,9 +40,9 @@ std::vector Credentials_Manager::find_cert_chain( } std::vector Credentials_Manager::cert_chain( - const std::vector&, - const std::string&, - const std::string&) + const std::vector& /*unused*/, + const std::string& /*unused*/, + const std::string& /*unused*/) { return std::vector(); } @@ -57,17 +57,17 @@ std::vector Credentials_Manager::cert_chain_single_type( return find_cert_chain(cert_types, std::vector(), type, context); } -Private_Key* Credentials_Manager::private_key_for(const X509_Certificate&, - const std::string&, - const std::string&) +Private_Key* Credentials_Manager::private_key_for(const X509_Certificate& /*unused*/, + const std::string& /*unused*/, + const std::string& /*unused*/) { return nullptr; } std::vector Credentials_Manager::trusted_certificate_authorities( - const std::string&, - const std::string&) + const std::string& /*unused*/, + const std::string& /*unused*/) { return std::vector(); } diff --git a/src/lib/tls/tls_callbacks.cpp b/src/lib/tls/tls_callbacks.cpp index 4b43359eb..7c8e8ae97 100644 --- a/src/lib/tls/tls_callbacks.cpp +++ b/src/lib/tls/tls_callbacks.cpp @@ -22,12 +22,12 @@ namespace Botan { -void TLS::Callbacks::tls_inspect_handshake_msg(const Handshake_Message&) +void TLS::Callbacks::tls_inspect_handshake_msg(const Handshake_Message& /*unused*/) { // default is no op } -std::string TLS::Callbacks::tls_server_choose_app_protocol(const std::vector&) +std::string TLS::Callbacks::tls_server_choose_app_protocol(const std::vector& /*unused*/) { return ""; } @@ -37,11 +37,11 @@ std::string TLS::Callbacks::tls_peer_network_identity() return ""; } -void TLS::Callbacks::tls_modify_extensions(Extensions&, Connection_Side) +void TLS::Callbacks::tls_modify_extensions(Extensions& /*unused*/, Connection_Side /*unused*/) { } -void TLS::Callbacks::tls_examine_extensions(const Extensions&, Connection_Side) +void TLS::Callbacks::tls_examine_extensions(const Extensions& /*unused*/, Connection_Side /*unused*/) { } diff --git a/src/lib/tls/tls_cbc/tls_cbc.cpp b/src/lib/tls/tls_cbc/tls_cbc.cpp index 72ea7737e..a516e74dd 100644 --- a/src/lib/tls/tls_cbc/tls_cbc.cpp +++ b/src/lib/tls/tls_cbc/tls_cbc.cpp @@ -282,7 +282,7 @@ void TLS_CBC_HMAC_AEAD_Decryption::cbc_decrypt_record(uint8_t record_contents[], cbc().process(record_contents, record_len); } -size_t TLS_CBC_HMAC_AEAD_Decryption::output_length(size_t) const +size_t TLS_CBC_HMAC_AEAD_Decryption::output_length(size_t /*input_length*/) const { /* * We don't know this because the padding is arbitrary diff --git a/src/lib/tls/tls_extensions.cpp b/src/lib/tls/tls_extensions.cpp index d6d2bf55c..6b0d8f550 100644 --- a/src/lib/tls/tls_extensions.cpp +++ b/src/lib/tls/tls_extensions.cpp @@ -462,7 +462,7 @@ std::vector SRTP_Protection_Profiles::serialize(Connection_Side /*whoam return buf; } -Extended_Master_Secret::Extended_Master_Secret(TLS_Data_Reader&, +Extended_Master_Secret::Extended_Master_Secret(TLS_Data_Reader& /*unused*/, uint16_t extension_size) { if(extension_size != 0) @@ -474,7 +474,7 @@ std::vector Extended_Master_Secret::serialize(Connection_Side /*whoami* return std::vector(); } -Encrypt_then_MAC::Encrypt_then_MAC(TLS_Data_Reader&, +Encrypt_then_MAC::Encrypt_then_MAC(TLS_Data_Reader& /*unused*/, uint16_t extension_size) { if(extension_size != 0) diff --git a/src/lib/tls/tls_handshake_io.cpp b/src/lib/tls/tls_handshake_io.cpp index b2370036d..e5ef9738d 100644 --- a/src/lib/tls/tls_handshake_io.cpp +++ b/src/lib/tls/tls_handshake_io.cpp @@ -49,7 +49,7 @@ Protocol_Version Stream_Handshake_IO::initial_record_version() const void Stream_Handshake_IO::add_record(const uint8_t record[], size_t record_len, - Record_Type record_type, uint64_t) + Record_Type record_type, uint64_t /*sequence_number*/) { if(record_type == HANDSHAKE) { @@ -69,7 +69,7 @@ void Stream_Handshake_IO::add_record(const uint8_t record[], } std::pair> -Stream_Handshake_IO::get_next_record(bool) +Stream_Handshake_IO::get_next_record(bool /*expecting_ccs*/) { if(m_queue.size() >= 4) { -- cgit v1.2.3