From 8d50c82b43b34b70d19b0faaeab6b37f2eae066c Mon Sep 17 00:00:00 2001 From: Jack Lloyd Date: Wed, 2 Nov 2016 15:05:46 -0400 Subject: Remove automatic self-testing of public and private keys Rarely expected and often causes performance problems, especially for private keys. Instead applications should call check_key explicitly to validate keys when necessary. Note this removal doesn't apply to tests like ECDH on-the-curve tests, where a check on the public key is required for security of our own key. Updates most APIs to remove RNG calls, where they are no longer required. Exception is PKCS8 interface, pending further work there (see GH #685) it just ignores the RNG argument now. --- src/lib/pubkey/elgamal/elgamal.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/lib/pubkey/elgamal/elgamal.h') diff --git a/src/lib/pubkey/elgamal/elgamal.h b/src/lib/pubkey/elgamal/elgamal.h index 102d5ad91..6b2e1b68f 100644 --- a/src/lib/pubkey/elgamal/elgamal.h +++ b/src/lib/pubkey/elgamal/elgamal.h @@ -62,11 +62,9 @@ class BOTAN_DLL ElGamal_PrivateKey : public ElGamal_PublicKey, * Load a private key. * @param alg_id the X.509 algorithm identifier * @param key_bits PKCS #8 structure - * @param rng the RNG to use */ ElGamal_PrivateKey(const AlgorithmIdentifier& alg_id, - const secure_vector& key_bits, - RandomNumberGenerator& rng); + const secure_vector& key_bits); /** * Create a private key. -- cgit v1.2.3