From ae59295ea945fdcc482df2233409a5f878fa20c7 Mon Sep 17 00:00:00 2001 From: lloyd Date: Tue, 14 Sep 2010 01:16:32 +0000 Subject: Completely remove the second parameter to SecureVector which specifies the initial/default length of the array, update all users to instead pass the value to the constructor. This is a old vestigal thing from a class (SecureBuffer) that used this compile-time constant in order to store the values in an array. However this was changed way back in 2002 to use the same allocator hooks as the rest of the containers, so the only advantage to using the length field was that the initial length was set and didn't have to be set in the constructor which was midly convenient. However this directly conflicts with the desire to be able to (eventually) use std::vector with a custom allocator, since of course vector doesn't support this. Fortunately almost all of the uses are in classes which have only a single constructor, so there is little to no duplication by instead initializing the size in the constructor. --- src/filters/base64/base64.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/filters/base64') diff --git a/src/filters/base64/base64.cpp b/src/filters/base64/base64.cpp index e342f7109..5f365ca5a 100644 --- a/src/filters/base64/base64.cpp +++ b/src/filters/base64/base64.cpp @@ -107,7 +107,8 @@ void Base64_Encoder::end_msg() if(left_over) { - SecureVector remainder(in + start_of_last_block, left_over); + SecureVector remainder(3); + copy_mem(&remainder[0], &in[start_of_last_block], left_over); encode(remainder, out); @@ -217,7 +218,8 @@ void Base64_Decoder::end_msg() if(left_over) { - SecureVector remainder(in + start_of_last_block, left_over); + SecureVector remainder(4); + copy_mem(&remainder[0], &in[start_of_last_block], left_over); decode(remainder, out); send(out, ((left_over == 1) ? (1) : (left_over - 1))); } -- cgit v1.2.3