aboutsummaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge GH #373 RDRAND/RDSEED logic changesJack Lloyd2016-03-063-34/+51
|\ | | | | | | The Intel RNG may fail if heavily contended, so retry as needed.
| * move logic back into poll()Daniel Neus2016-01-262-60/+36
| | | | | | | | prevents filtering out any 0x00000000 outputs from RDRAND/RDSEED
| * review changesDaniel Neus2015-12-215-37/+42
| | | | | | | | | | | | | | | | * no spaces around if(), for() etc * snake_case for plain functions * anonymous namespace function instead private and static * don't propagate failed poll to the calling application * RdRand retires configurable in build.h
| * RdRand and RdSeed logic changesDaniel Neus2015-12-205-36/+72
| | | | | | | | | | * Make it configurable how often RdRand and RdSeed is polled * Make it configurable how many RdSeed retries are executed
* | Typos are easy to miss in code that is not compiled by default.Jack Lloyd2016-03-061-1/+1
| |
* | Merge GH #437 add X509_Certificate::v3_extensionsJack Lloyd2016-03-064-20/+35
|\ \ | | | | | | | | | | | | Makes it possible for an application to interpret some extension not supported by the library.
| * | +added fields for custom x509 extensionsChristopher Bläsius2016-02-294-20/+33
| | | | | | | | | | | | +Extensions now uses std::unique_ptr
* | | Merge GH #441 Clang analyzer fixesJack Lloyd2016-03-063-5/+7
|\ \ \
| * \ \ Merge branch 'master' into clang-analyzerDaniel Neus2016-03-06136-346/+359
| |\ \ \
| * | | | added an assert for aes key length >= 4 in aes_key_schedule to prevent ↵Daniel Neus2016-03-021-0/+6
| | | | | | | | | | | | | | | | | | | | division by zero found by clang-analyzer
| * | | | fix dead assignment / redundant computation in block/aes_ssse3/aes_ssse3.cpp ↵Daniel Neus2016-03-021-2/+0
| | | | | | | | | | | | | | | | | | | | in aes_schedule_transform found by clang-analyzer
| * | | | fix dead assignment in mce/polyn_gf2m.cpp in polyn_gf2m() found by ↵Daniel Neus2016-03-021-3/+1
| | | | | | | | | | | | | | | | | | | | clang-analyzer
| * | | | fixed another dead assignment found by clang-analyzer in test_dtls_handshake()Daniel Neus2016-03-021-1/+1
| | | | |
| * | | | fix dead assignment found by clang-analyzer in test_dtls_handshake()Daniel Neus2016-03-021-1/+1
| | |/ / | |/| |
* | | | Check that TLS signature type is accepted by the policy.Jack Lloyd2016-03-069-38/+106
| |/ / |/| | | | | | | | | | | | | | Previously the signature hashes and algos info was used to set the v1.2 signature_algorithms extension, but if the counterparty ignored the extension and sent something else, we wouldn't notice.
* | | Fix ordering of Charset::transcode argumentsJack Lloyd2016-03-062-2/+2
| | | | | | | | | | | | GH #438
* | | Remaining cppcheck fixes that are not covered by GH #444Daniel Neus2016-03-0534-136/+141
| | |
* | | Remove explicit from DL_Group, EC_Group constructors taking std::stringJack Lloyd2016-03-052-2/+2
| | | | | | | | | | | | | | | | | | I think we maybe want these to be converting constructors, and adding explicit here breaks code like ECDSA_PrivateKey(rng, "secp256r1") which seems like a reasonable thing to support IMO
* | | cppcheck fixes: Class 'X' has a constructor with 1 argument that is not ↵Daniel Neus2016-03-05106-213/+214
| | | | | | | | | | | | explicit.
* | | Merge pull request #440 from neusdan/os_utils_process_id_fixJack Lloyd2016-03-021-2/+2
|\ \ \ | | | | | | | | Fix a typo in os_utils that prevents retrieval of the current process id on Windows
| * | | fix a typo in os_utils that prevents retrieval of the current process id on ↵Daniel Neus2016-03-011-2/+2
| |/ / | | | | | | | | | windows
* / / Skip bzip2 compression in entropy tests on OS X due to GH #394Jack Lloyd2016-03-021-0/+7
|/ / | | | | | | | | Feels kind of nasty, but it sucks more to have CI builds break because of random failures.
* | Merge pull request #431 from cordney/python-improvementsJack Lloyd2016-02-214-17/+93
|\ \ | | | | | | Improvements in X.509 cert handling for python bindings. Add Python code coverage report.
| * | Add LD_LIBRARY_PATH to python coverageRené Korthaus2016-02-201-1/+1
| | |
| * | Run coverage for python bindingsRené Korthaus2016-02-202-0/+4
| | |
| * | Remove tabRené Korthaus2016-02-201-1/+1
| | |
| * | Improvements in X.509 cert handling for python bindingsRené Korthaus2016-02-202-17/+89
| | | | | | | | | | | | | | | | | | | | | | | | Add implementation for ffi botan_x509_cert_get_public_key(). Add subject_dn() function to python x509_cert class. Have python x509_cert constructor take a buffer alternatively. Have python x509_cert functions time_starts() and time_expires() return a python timestamp.
* | | Add more tests for modular inverseJack Lloyd2016-02-212-4/+475
| | | | | | | | | | | | | | | The result of fuzzing with AFL for a while, then running cmin on the result.
* | | Avoid some Wshadows in GCC 4.8Jack Lloyd2016-02-203-11/+10
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | In GCC 4.7 and 4.8, Wshadow also warns if a local variable conflicts with a member function. This was changed in GCC 4.9 (GCC bugzilla 57709) but causes a lot of warnings on Travis which is on 4.8. Clang's Wshadow behaves like GCC 4.9 The worst offendor was Exception's constructor argument being named `what` which conflicts with the member function of the same name, being in a public header this causes so many warnings the Travis log files are truncated. This fixes Exception and a couple of others. Fixing all cases would be a slog that I'm not up for right at the moment.
* | For odd moduli use a input-independent modular inverse algorithm.Jack Lloyd2016-02-207-62/+311
| | | | | | | | Also adds a (not const time) implementation of almost Montgomery reduction.
* | Add tests and timings for inverse_modJack Lloyd2016-02-205-14/+103
| |
* | Merge GH #427 Fix remaining Wshadow warningsJack Lloyd2016-02-2016-106/+111
|\ \
| * | Fix remaining Wshadow warnings and enable on gcc and clangRené Korthaus2016-02-1816-106/+111
| | |
* | | Merge GH #428 Add missing include guardsJack Lloyd2016-02-202-0/+10
|\ \ \
| * | | add missing include guardsDaniel Neus2016-02-192-0/+10
| |/ /
* / / enable noexcept on VS 2015Daniel Neus2016-02-191-1/+1
|/ /
* | correct appveyor matrixDaniel Neus2016-02-171-3/+7
| |
* | add VS2015 jobsDaniel Neus2016-02-171-2/+9
| |
* | Split up BigInt testsJack Lloyd2016-02-1713-2727/+2408
| | | | | | | | | | | | Removes a fair number of the power mod test cases for size and test time. Would be better to add a randomized or fuzzer-based test. Otherwise no change.
* | Add constant time conditional swap, add, sub for bigint wordsJack Lloyd2016-02-175-2/+233
| | | | | | | | | | | | | | | | | | Not optimized and relies on asm support for const time word_add/word_sub instructions. Fix a bug introduced in 46e9a89 - unpoison needs to call the valgrind API with the pointer rather than the reference. Caused values not to be unpoisoned.
* | Reject zero length TLS records out of hand.Jack Lloyd2016-02-161-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Later checks on the record length in CCS and record handling already rejected a zero length record but when reading an empty record, readbuf.size() == TLS_HEADER_SIZE and so creating the pointer byte* record_contents = &readbuf[TLS_HEADER_SIZE]; would trigger when running under (at least) GCC'S iterator debugging, and likely other iterator checkers also. Since no completely empty record is defined, reject it immediately at the record layer. Found by Juraj Somorovsky Also correct DTLS record handling for large messages: a zero length or too-long packet should be dropped rather than an exception being thrown.
* | Add KDF1 as explicit dependency in MCEIESJack Lloyd2016-02-151-0/+1
| | | | | | | | | | | | | | | | | | | | Previously MCEIES used KEM with a raw SHA-512 hash. When the KDF oriented KEM interface was added in 72f0f0ad2a it switched to using KDF1(SHA-512) since for a 64-byte output and no salt, the output matches the original hash. This avoids breaking the format. Prevents runtime failures when MCEIES is enabled in the build but KDF1 is not. GH #369
* | In compression wrappers add an overflow check before calling mallocJack Lloyd2016-02-131-3/+21
| | | | | | | | | | | | | | | | | | | | If malloc fails, don't save the size that was attempted. Otherwise a failing malloc followed by a free(nullptr) would zero a block of memory equal to the failed allocation starting from the null address. It's not clear if zlib,bzip2,lzma expect the return of the malloc function to be zero but LZMA at least seems to read from it before writing. Zero it.
* | Add --with-valgrindJack Lloyd2016-02-131-6/+0
| |
* | Fix Coverity findings in McEliece codeJack Lloyd2016-02-093-14/+20
| | | | | | | | | | | | | | | | Initialize variables in constructor in gf2m_decomp_rootfind_state Add asserts on the degree where a positive value was assumed. How polyn_gf2m handles the degree needs some work but this should do for now.
* | Add asserts to help out CoverityJack Lloyd2016-02-092-0/+4
| | | | | | | | | | | | It somehow deduces an input that is both > 0 and for which high_bit never finds a bit set and returns 0. In both cases that would lead to block being 0 and a negative shift.
* | Check result of dynamic_castJack Lloyd2016-02-091-10/+17
| | | | | | | | | | | | Unlikely to fail in this case but anything's possible. Found by Coverity
* | Removes randomization from choice of keys in X509 test.Jack Lloyd2016-02-091-17/+15
| | | | | | | | | | | | | | Would be better to iterate over all of the key types for this type of coverage. Avoids Coverity dead code warning on the error-case throw.
* | Fix memory leaks in FFI testsJack Lloyd2016-02-091-7/+16
| | | | | | | | | | | | | | | | | | | | Some tests only deallocated in the branch where some other test on the object succeeded. The ECDH FFI test didn't deallocate any of its objects, which was missed by valgrind before now because the test was not being run. Found by Coverity scanner
* | Avoid Coverity false positiveJack Lloyd2016-02-091-1/+5
| | | | | | | | | | | | | | | | It assumes unpoison is expecting a pointer to T and sizeof(T), but the sizeof is evaluated in unpoison but only in the case of building with valgrind. Just call the valgrind API again directly
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-25 00:57:22 +0000