Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove redundant parens | Jack Lloyd | 2017-10-03 | 7 | -8/+8 |
| | | | | Sonar | ||||
* | Remove redundant return statement | Jack Lloyd | 2017-10-02 | 1 | -1/+1 |
| | |||||
* | Remove various unused variables | Jack Lloyd | 2017-10-02 | 3 | -4/+0 |
| | | | | Sonar finds | ||||
* | Remove unnecessary virtuals from final classes | Jack Lloyd | 2017-10-02 | 6 | -10/+6 |
| | | | | Found with Sonar | ||||
* | Uppercase constants | Jack Lloyd | 2017-10-02 | 1 | -12/+15 |
| | |||||
* | Use class for exception types | Jack Lloyd | 2017-10-02 | 2 | -5/+9 |
| | |||||
* | Remove protected functions from final classes | Jack Lloyd | 2017-10-02 | 8 | -38/+8 |
| | | | | | | Mostly residue from the old system of splitting impls among subclasses Found with Sonar | ||||
* | Make TLS::Blocking_Client non-final | Jack Lloyd | 2017-10-02 | 1 | -1/+1 |
| | | | | It is intended for derivation! Just not tested... | ||||
* | sigemptyset is a macro on OS X | Jack Lloyd | 2017-10-02 | 1 | -1/+1 |
| | |||||
* | Remove protected m_handle data from PKCS11::Object | Jack Lloyd | 2017-10-02 | 3 | -6/+18 |
| | |||||
* | Make m_emsa in PK_{Signature,Verification}_with_EMSA private | Jack Lloyd | 2017-10-02 | 2 | -4/+7 |
| | |||||
* | Make EMSA1 data private | Jack Lloyd | 2017-10-02 | 1 | -6/+4 |
| | | | | It was already final so leaving data as protected makes no sense... | ||||
* | Make kv in TLS_Text_Policy private, add protected setter | Jack Lloyd | 2017-10-02 | 2 | -0/+14 |
| | |||||
* | Remove protected data members from X509_Object | Jack Lloyd | 2017-10-02 | 5 | -41/+27 |
| | | | | Just need const accessors, no reason for any subclass to modify values. | ||||
* | Remove needless block | Jack Lloyd | 2017-10-02 | 1 | -11/+7 |
| | |||||
* | Avoid using namespace in FFI headers | Jack Lloyd | 2017-10-02 | 5 | -7/+3 |
| | | | | Internal only headers but Sonar doesn't know that | ||||
* | Prefix names in global namespace with :: | Jack Lloyd | 2017-10-02 | 3 | -7/+7 |
| | |||||
* | Remove redundant "virtual override" declarations. | Jack Lloyd | 2017-10-02 | 8 | -36/+34 |
| | |||||
* | Fix some cast warnings from Sonar | Jack Lloyd | 2017-10-01 | 5 | -6/+6 |
| | |||||
* | Use explicit :: or std:: to refer to functions in namespaces | Jack Lloyd | 2017-10-01 | 1 | -1/+1 |
| | |||||
* | Use explicit_bzero on OpenBSD | Jack Lloyd | 2017-09-30 | 1 | -2/+7 |
| | | | | [ci skip] | ||||
* | Remove unused namespace | Jack Lloyd | 2017-09-30 | 1 | -4/+0 |
| | |||||
* | Avoid -size_t | Jack Lloyd | 2017-09-30 | 1 | -1/+1 |
| | |||||
* | Guard against self-assignment | Jack Lloyd | 2017-09-30 | 2 | -0/+6 |
| | | | | Found with Sonar | ||||
* | Change this code so Sonar understands div by zero can't happen | Jack Lloyd | 2017-09-30 | 1 | -2/+3 |
| | |||||
* | Another FFI struct vs class fix | Jack Lloyd | 2017-09-30 | 1 | -1/+1 |
| | |||||
* | Retract explicit on OID | Jack Lloyd | 2017-09-30 | 1 | -1/+1 |
| | | | | This conversion is often useful | ||||
* | FFI objects have to be structs because we expose them to C | Jack Lloyd | 2017-09-30 | 2 | -5/+4 |
| | |||||
* | Use explicit on more single-argument constructors | Jack Lloyd | 2017-09-30 | 14 | -20/+23 |
| | |||||
* | Avoid bogus declarations in GMAC | Jack Lloyd | 2017-09-30 | 1 | -25/+3 |
| | | | | | These functions are declared/defined on MessageAuthenticationCode, and call the start_msg virtual. | ||||
* | Address some MSVC warnings | Jack Lloyd | 2017-09-30 | 7 | -134/+139 |
| | |||||
* | Use class instead of struct for objects with member functions | Jack Lloyd | 2017-09-30 | 13 | -156/+183 |
| | | | | Flagged by Sonar and quite reasonable | ||||
* | Add annotation so GCC/Clang/MSVC know it is an allocation function. | Jack Lloyd | 2017-09-30 | 2 | -1/+12 |
| | |||||
* | Merge GH #1231 Hide secure_allocator allocate in a function | Jack Lloyd | 2017-09-30 | 5 | -22/+55 |
|\ | |||||
| * | Missing include, noticed by OS X | Jack Lloyd | 2017-09-29 | 1 | -0/+1 |
| | | |||||
| * | In secure_allocator, hide mlock/new usage in a function in mem_ops | Jack Lloyd | 2017-09-29 | 5 | -22/+54 |
| | | | | | | | | | | | | | | Switch to calloc/free instead of new/delete - shouldn't matter since we are only allocate integral types. This change reduces the size of libbotan-2.so by ~300 Kb on my system. | ||||
* | | Thinko fix | Jack Lloyd | 2017-09-30 | 1 | -1/+1 |
| | | |||||
* | | Compat typedef PBKDF -> S2K | Jack Lloyd | 2017-09-29 | 1 | -1/+12 |
|/ | | | | [ci skip] | ||||
* | Avoid throwing in pool allocator deallocation path | Jack Lloyd | 2017-09-29 | 1 | -8/+1 |
| | | | | | | std::terminate can ruin your day Coverity find | ||||
* | Merge GH #1229 Simplify allocator and avoid MSVC perf issue | Jack Lloyd | 2017-09-29 | 1 | -37/+5 |
|\ | |||||
| * | Add back size_type typedef | Jack Lloyd | 2017-09-29 | 1 | -0/+1 |
| | | | | | | | | | | | | | | Lacking this seems to cause interesting issues with Apple Clang on 32-bit ARM. It seems like it implicitly defines a size_type that is the same size as size_t, but not actually size_t, so we get an unsigned long vs unsigned int mismatch on the type. | ||||
| * | Of course MSVC 2013 has to be special | Jack Lloyd | 2017-09-29 | 1 | -0/+7 |
| | | |||||
| * | Simplifiy secure_allocator | Jack Lloyd | 2017-09-29 | 1 | -44/+4 |
| | | | | | | | | | | | | | | | | | | According to https://howardhinnant.github.io/allocator_boilerplate.html we don't need most of what was in there in C++11 and later. I think I originally wrote that code referencing a C++03 doc. Specifically avoiding construct, destruct prevents a performance issue in MSVC (GH #1228) | ||||
* | | In TLS CBC padding check, only need to verify last 256 bytes | Jack Lloyd | 2017-09-29 | 1 | -8/+16 |
|/ | | | | | No reason to scan the entire record since it's assured at most 256 bytes of padding are used. Inspired by GH #1227 | ||||
* | Add a test of TLS CBC padding verification | Jack Lloyd | 2017-09-29 | 2 | -9/+12 |
| | | | | See also GH #1227 | ||||
* | Include pk_keys.h in pkcs8.h and x509_key.h | Jack Lloyd | 2017-09-29 | 2 | -2/+2 |
| | | | | Not strictly required but seems likely to cause problems for applications. | ||||
* | Require HMAC for HKDF | Jack Lloyd | 2017-09-28 | 1 | -0/+4 |
| | | | | Not actually strictly required but in practice doesn't make much sense. | ||||
* | Fixes for MSVC | Jack Lloyd | 2017-09-28 | 2 | -2/+2 |
| | | | | BOTAN_UNUSED "uses" the RNG :/ | ||||
* | Further header cleanups | Jack Lloyd | 2017-09-28 | 17 | -9/+29 |
| | |||||
* | Add variants of PKCS8::load_key that don't require an RNG argument | Jack Lloyd | 2017-09-28 | 2 | -32/+112 |
| | | | | | It's not used and only there for compat with existing callers, but no reason we can't offer a version that doesn't require it. |