Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Attempt to verify decoded ECC groups are using prime fields | Jack Lloyd | 2018-06-20 | 2 | -5/+57 |
| | | | | | | | Otherwise ressol (part of point decompression) can end up in very long loop. OSS-Fuzz 9011 | ||||
* | Add todo | Jack Lloyd | 2018-06-20 | 1 | -0/+1 |
| | | | | GH #1612 | ||||
* | Avoid an unncecessary malloc | Jack Lloyd | 2018-06-20 | 1 | -1/+1 |
| | |||||
* | Use masked table lookups for variable point scalar mult | Jack Lloyd | 2018-06-20 | 2 | -16/+36 |
| | |||||
* | Changes to allow masked lookups for variable point mult | Jack Lloyd | 2018-06-20 | 8 | -146/+174 |
| | |||||
* | Fix SM2 encryption tests | Jack Lloyd | 2018-06-20 | 1 | -3/+4 |
| | | | | Broken in 5f26125d | ||||
* | Update side channel doc | Jack Lloyd | 2018-06-20 | 1 | -9/+25 |
| | |||||
* | Remove build time toggle for ECC coordinate masking | Jack Lloyd | 2018-06-20 | 3 | -23/+16 |
| | | | | | | | | | This is not a decision we should leave to end users. And always use a random mask equal in size to the underlying field. It was never quite clear if 80 bits was sufficient or not. But taking a random field element is clearly the best possible situation, and has very little additional cost. | ||||
* | Perform ECC mult starting from top bit of the exponent | Jack Lloyd | 2018-06-20 | 1 | -17/+16 |
| | | | | | | | Since we know the top bit is 1, then R will always be a point other than point at infinity after the very first addition regardless of the scalar or mask, so then coordinate randomization is guaranteed to work. | ||||
* | Avoid a small timing channel in Barrett reduction | Jack Lloyd | 2018-06-20 | 2 | -25/+31 |
| | | | | No known exploit for this but no point taking chances. | ||||
* | More cli tests | Jack Lloyd | 2018-06-19 | 1 | -0/+27 |
| | |||||
* | Ensure that trying to add points from different groups fails. | Jack Lloyd | 2018-06-19 | 3 | -13/+35 |
| | | | | Producing garbage instead is asking for trouble. | ||||
* | Use masked table lookup in ECC base point multiplication | Jack Lloyd | 2018-06-19 | 2 | -9/+42 |
| | |||||
* | Avoid a special case in Barrett reduction for x < mod | Jack Lloyd | 2018-06-18 | 1 | -8/+3 |
| | | | | This would have prevented CVE-2018-12435 | ||||
* | Avoid unnecessary realloc in BigInt::mod_sub | Jack Lloyd | 2018-06-17 | 1 | -2/+7 |
| | |||||
* | Add some todo comments wrt side channels in ECC scalar mult | Jack Lloyd | 2018-06-17 | 1 | -0/+5 |
| | |||||
* | Merge GH #1610 Make exponentiation loop independent of exponent size | Jack Lloyd | 2018-06-17 | 11 | -51/+119 |
|\ | |||||
| * | Avoid leaking size of exponent | Jack Lloyd | 2018-06-17 | 11 | -51/+119 |
|/ | | | | See #1606 for discussion | ||||
* | Merge GH #1609 Avoid small side channel in ECC field mul | Jack Lloyd | 2018-06-15 | 1 | -22/+15 |
|\ | |||||
| * | In ECC avoid using significant words to dispatch the mult algo | Jack Lloyd | 2018-06-15 | 1 | -22/+15 |
| | | | | | | | | | | | | Normally all elements will be exact number of limbs as the field. Any situation with short elements is rare and not worth optimizing for, and likely leads to some unfortunate side channel. | ||||
* | | Merge GH #1608 Fix TLS when x25519 is disabled | Jack Lloyd | 2018-06-15 | 6 | -8/+18 |
|\ \ | |||||
| * | | TLS would try to negotiate x25519 even if disabled | Jack Lloyd | 2018-06-15 | 6 | -8/+18 |
| |/ | | | | | | | | | | | | | | | Also reorder ECC groups to actually match performance characteristics. I'm not sure when P-384 was slower than P-521 but it certainly isn't anymore. Fixes #1607 | ||||
* / | Use Botan specific CVE for ECDSA side channel [ci skip] | Jack Lloyd | 2018-06-15 | 2 | -4/+3 |
|/ | |||||
* | Update news | Jack Lloyd | 2018-06-15 | 1 | -0/+2 |
| | |||||
* | Merge GH #1606 Make Montgomery exponentation const time | Jack Lloyd | 2018-06-15 | 7 | -60/+124 |
|\ | |||||
| * | Document leak of exponent size | Jack Lloyd | 2018-06-14 | 1 | -2/+4 |
| | | |||||
| * | Add combined conditional add-or-subtract | Jack Lloyd | 2018-06-14 | 3 | -5/+41 |
| | | |||||
| * | Remove CT annotations from Montgomery reduction | Jack Lloyd | 2018-06-14 | 1 | -8/+0 |
| | | | | | | | | | | The poisons don't stack so the unpoison hid conditional jumps we want to find. | ||||
| * | In Montgomery mul, avoid branching based on sig words of integers | Jack Lloyd | 2018-06-14 | 1 | -13/+21 |
| | | | | | | | | Instead just assume they are the same size as the prime | ||||
| * | Make Karatsuba multiply completely const time | Jack Lloyd | 2018-06-14 | 5 | -36/+62 |
|/ | |||||
* | Fix CLI test | Jack Lloyd | 2018-06-14 | 1 | -0/+1 |
| | |||||
* | Avoid overallocation of memory for EC base point multiples | Jack Lloyd | 2018-06-14 | 1 | -1/+1 |
| | | | | | | | The size is rounded up to next 8 words so there was substantial slack here. No noticable perf difference. | ||||
* | Merge GH #1605 Add 192-bit Suite B TLS policy | Jack Lloyd | 2018-06-14 | 7 | -8/+74 |
|\ | |||||
| * | Add 192-bit Suite B policy | Jack Lloyd | 2018-06-14 | 7 | -8/+74 |
| | | | | | | | | Since 128-bit policy is actually not even allowed since 2015. | ||||
* | | Output order with ec_group_info | Jack Lloyd | 2018-06-14 | 1 | -0/+1 |
| | | |||||
* | | Update news [ci skip] | Jack Lloyd | 2018-06-14 | 1 | -0/+4 |
|/ | |||||
* | Merge GH #1604 Resolve ECDSA/DSA side channel | Jack Lloyd | 2018-06-13 | 5 | -17/+88 |
|\ | |||||
| * | Address DSA/ECDSA side channel | Jack Lloyd | 2018-06-13 | 5 | -17/+88 |
|/ | |||||
* | Merge GH #1603 Unroll Montgomery reduction for specific sizes | Jack Lloyd | 2018-06-11 | 7 | -26/+2784 |
|\ | |||||
| * | Unroll bigint_monty_redc for various sizes | Jack Lloyd | 2018-06-11 | 7 | -26/+2784 |
| | | | | | | | | Speedup of 10 to 30% depending on algo | ||||
* | | Merge GH #1602 Support GCC --sysroot option for embedded cross compiles | Jack Lloyd | 2018-06-11 | 5 | -1/+20 |
|\ \ | |/ |/| | |||||
| * | Corrected error message | Hegedüs Márton Csaba | 2018-06-11 | 1 | -1/+1 |
| | | |||||
| * | Required changes according to the code review | Hegedüs Márton Csaba | 2018-06-11 | 4 | -5/+16 |
| | | |||||
| * | Updated news.rst | Hegedüs Márton Csaba | 2018-06-08 | 1 | -0/+2 |
| | | |||||
| * | Add support for GCC's --sysroot option to configure.py | Hegedüs Márton Csaba | 2018-06-08 | 2 | -2/+8 |
|/ | |||||
* | Merge GH #1601 Fix typos in configure script [ci skip] | Jack Lloyd | 2018-06-08 | 1 | -2/+2 |
|\ | |||||
| * | Fix some typos in configure.py | Felix Yan | 2018-06-09 | 1 | -2/+2 |
|/ | |||||
* | Add missing statement | Jack Lloyd | 2018-06-08 | 1 | -0/+1 |
| | |||||
* | Merge GH #1600 Optimizations in BER decoding | Jack Lloyd | 2018-06-08 | 9 | -102/+252 |
|\ | |||||
| * | Attempt at MSVC 2013 workaround | Jack Lloyd | 2018-06-08 | 1 | -2/+4 |
| | |