diff options
-rw-r--r-- | circle.yml | 4 | ||||
-rwxr-xr-x | configure.py | 141 | ||||
-rw-r--r-- | src/build-data/buildh.in | 2 | ||||
-rw-r--r-- | src/build-data/cc/clang.txt | 7 | ||||
-rw-r--r-- | src/build-data/cc/ekopath.txt | 7 | ||||
-rw-r--r-- | src/build-data/cc/gcc.txt | 9 | ||||
-rw-r--r-- | src/build-data/cc/hpcc.txt | 11 | ||||
-rw-r--r-- | src/build-data/cc/icc.txt | 7 | ||||
-rw-r--r-- | src/build-data/cc/msvc.txt | 17 | ||||
-rw-r--r-- | src/build-data/cc/pgi.txt | 7 | ||||
-rw-r--r-- | src/build-data/cc/sunstudio.txt | 7 | ||||
-rw-r--r-- | src/build-data/cc/xlc.txt | 7 | ||||
-rw-r--r-- | src/build-data/makefile/header.in | 15 | ||||
-rwxr-xr-x | src/scripts/ci/circle/clang-shared-debug.sh | 2 | ||||
-rwxr-xr-x | src/scripts/ci/circle/clang-static-debug.sh | 2 | ||||
-rwxr-xr-x | src/scripts/ci/circle/gcc-sanitizer.sh | 11 | ||||
-rwxr-xr-x | src/scripts/ci/circle/gcc-shared-debug.sh | 2 | ||||
-rwxr-xr-x | src/scripts/ci/circle/gcc-static-debug.sh | 2 | ||||
-rwxr-xr-x | src/scripts/ci/travis/build.sh | 5 | ||||
-rw-r--r-- | src/tests/test_ffi.cpp | 3 |
20 files changed, 126 insertions, 142 deletions
diff --git a/circle.yml b/circle.yml index 5355df733..48688eb60 100644 --- a/circle.yml +++ b/circle.yml @@ -5,9 +5,9 @@ dependencies: - wget -q -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add - - sudo apt-get update -qq override: - - sudo apt-get install g++-4.8 clang-3.6 + - sudo apt-get install g++-4.9 clang-3.6 post: - - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.8 99 + - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.9 99 - sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-3.6 99 - g++ --version - clang++ --version diff --git a/configure.py b/configure.py index 1c6dfedc7..122e493f3 100755 --- a/configure.py +++ b/configure.py @@ -260,16 +260,19 @@ def process_command_line(args): build_group = optparse.OptionGroup(parser, 'Build options') - build_modes = ['release', 'debug', 'coverage', 'sanitizer'] - build_group.add_option('--build-mode', default='release', metavar='MODE', - choices=build_modes, - help="Build mode (one of %s; default %%default)" % (', '.join(build_modes))) + build_group.add_option('--with-debug-info', action='store_true', default=False, dest='with_debug_info', + help='enable debug info') + # For compat and convenience: + build_group.add_option('--debug-mode', action='store_true', default=False, dest='with_debug_info', + help=optparse.SUPPRESS_HELP) + + build_group.add_option('--with-sanitizers', action='store_true', default=False, dest='with_sanitizers', + help='enable runtime checks') - build_group.add_option('--debug-mode', action='store_const', - const='debug', dest='build_mode', - help='enable debugging build') + build_group.add_option('--with-coverage', action='store_true', default=False, dest='with_coverage', + help='enable coverage checking') - build_group.add_option('--enable-shared', dest='build_shared_lib', + build_group.add_option('--enable-shared-library', dest='build_shared_lib', action='store_true', default=True, help=optparse.SUPPRESS_HELP) build_group.add_option('--disable-shared', dest='build_shared_lib', @@ -278,7 +281,7 @@ def process_command_line(args): build_group.add_option('--no-optimizations', dest='no_optimizations', action='store_true', default=False, - help=optparse.SUPPRESS_HELP) + help='disable all optimizations (for debugging)') build_group.add_option('--gen-amalgamation', dest='gen_amalgamation', default=False, action='store_true', @@ -447,6 +450,9 @@ def process_command_line(args): options.disable_intrinsics = parse_multiple_enable(options.disable_intrinsics) + if options.maintainer_mode: + options.with_sanitizers = True + return options """ @@ -773,12 +779,9 @@ class CompilerInfo(object): 'add_lib_dir_option': '-L', 'add_lib_option': '-l', 'add_framework_option': '-framework ', - 'compile_flags_release': '', - 'compile_flags_debug': '', - 'lib_opt_flags_release': '', - 'lib_opt_flags_debug': '', - 'app_opt_flags_release': '', - 'app_opt_flags_debug': '', + 'compile_flags': '', + 'debug_info_flags': '', + 'optimization_flags': '', 'coverage_flags': '', 'sanitizer_flags': '', 'shared_flags': '', @@ -845,7 +848,7 @@ class CompilerInfo(object): """ def mach_abi_link_flags(self, options): def all(): - if 'all-debug' in self.mach_abi_linking and options.build_mode == 'debug': + if options.with_debug_info and 'all-debug' in self.mach_abi_linking: return 'all-debug' return 'all' @@ -855,50 +858,42 @@ class CompilerInfo(object): if flag != None and flag != '' and flag not in abi_link: abi_link.append(flag) - abi_flags = '' - if len(abi_link) > 0: - abi_flags += ' '.join(sorted(abi_link)) - if options.cc_abi_flags != '': - abi_flags += ' ' + options.cc_abi_flags - - if options.build_mode == 'coverage': + if options.with_coverage: if self.coverage_flags == '': raise Exception('No coverage handling for %s' % (self.basename)) - return ' ' + self.coverage_flags + ' ' + abi_flags - elif options.build_mode == 'sanitizer': + abi_link.append(self.coverage_flags) + + if options.with_sanitizers: if self.sanitizer_flags == '': raise Exception('No sanitizer handling for %s' % (self.basename)) - return ' ' + self.sanitizer_flags + ' ' + abi_flags + abi_link.append(self.sanitizer_flags) - return ' ' + abi_flags + abi_flags = ' '.join(sorted(abi_link)) - """ - Return the optimization flags to use - """ - def opt_flags(self, who, options): + if options.cc_abi_flags != '': + abi_flags += ' ' + options.cc_abi_flags + + if abi_flags != '': + return ' ' + abi_flags + return '' + + def cc_warning_flags(self, options): def gen_flags(): - if options.build_mode in ['debug', 'coverage']: - yield self.compile_flags_debug - else: - yield self.compile_flags_release + yield self.warning_flags + if options.maintainer_mode: + yield self.maintainer_warning_flags - if options.no_optimizations or options.build_mode == 'coverage': - return + return (' '.join(gen_flags())).strip() - if who == 'app': - if options.build_mode == 'release': - yield self.app_opt_flags_release - else: - yield self.app_opt_flags_debug - return - elif who == 'lib': - if options.build_mode == 'release': - yield self.lib_opt_flags_release - else: - yield self.lib_opt_flags_debug - return - else: - raise Exception("Invalid value of parameter 'who'.") + def cc_compile_flags(self, options): + def gen_flags(): + yield self.lang_flags + + if options.with_debug_info: + yield self.debug_info_flags + + if not options.no_optimizations: + yield self.optimization_flags def submodel_fixup(flags, tup): return tup[0].replace('SUBMODEL', flags.replace(tup[1], '')) @@ -916,16 +911,17 @@ class CompilerInfo(object): return (' '.join(gen_flags())).strip() + def _so_link_search(self, osname, debug_info): + if debug_info: + return [osname + '-debug', 'default-debug'] + else: + return [osname, 'default'] + """ Return the command needed to link a shared object """ def so_link_command_for(self, osname, options): - if options.build_mode == 'debug': - search_for = [osname + "-debug", 'default-debug'] - else: - search_for = [osname, 'default'] - - for s in search_for: + for s in self._so_link_search(osname, options.with_debug_info): if s in self.so_link_commands: return self.so_link_commands[s] @@ -936,12 +932,7 @@ class CompilerInfo(object): Return the command needed to link an app/test object """ def binary_link_command_for(self, osname, options): - if options.build_mode == 'debug': - search_for = [osname + "-debug", 'default-debug'] - else: - search_for = [osname, 'default'] - - for s in search_for: + for s in self._so_link_search(osname, options.with_debug_info): if s in self.binary_link_commands: return self.binary_link_commands[s] @@ -1146,12 +1137,13 @@ def gen_makefile_lists(var, build_config, options, modules, cc, arch, osinfo): """ def build_commands(sources, obj_dir, flags): for (obj_file,src) in zip(objectfile_list(sources, obj_dir), sources): - yield '%s: %s\n\t$(CXX)%s $(%s_FLAGS) %s%s %s %s$@\n' % ( + yield '%s: %s\n\t$(CXX)%s $(%s_FLAGS) %s%s %s %s %s$@\n' % ( obj_file, src, isa_specific_flags(cc, src), flags, cc.add_include_dir_option, build_config.include_dir, + cc.compile_flags, src, cc.output_to_option) @@ -1216,14 +1208,6 @@ def create_template_vars(build_config, options, modules, cc, arch, osinfo): return os.path.join(options.with_build_dir, path) return path - def warning_flags(normal_flags, - maintainer_flags, - maintainer_mode): - if maintainer_mode and maintainer_flags != '': - return normal_flags + ' ' + maintainer_flags - else: - return normal_flags - def innosetup_arch(os, arch): if os == 'windows': inno_arch = { 'x86_32': '', 'x86_64': 'x64', 'ia64': 'ia64' } @@ -1295,15 +1279,12 @@ def create_template_vars(build_config, options, modules, cc, arch, osinfo): 'mp_bits': choose_mp_bits(), - 'cxx': (options.compiler_binary or cc.binary_name) + cc.mach_abi_link_flags(options), + 'cxx': (options.compiler_binary or cc.binary_name), + 'cxx_abi_flags': cc.mach_abi_link_flags(options), 'linker': cc.linker_name or '$(CXX)', - 'lib_opt': cc.opt_flags('lib', options), - 'app_opt': cc.opt_flags('app', options), - 'lang_flags': cc.lang_flags, - 'warn_flags': warning_flags(cc.warning_flags, - cc.maintainer_warning_flags, - options.maintainer_mode), + 'cc_compile_flags': cc.cc_compile_flags(options), + 'cc_warning_flags': cc.cc_warning_flags(options), 'shared_flags': cc.gen_shared_flags(options), 'visibility_attribute': cc.gen_visibility_attribute(options), @@ -1381,7 +1362,7 @@ def create_template_vars(build_config, options, modules, cc, arch, osinfo): vars["gmake_dso_in"] = process_template('src/build-data/makefile/gmake_dso.in', vars) \ if options.build_shared_lib else '' vars["gmake_coverage_in"] = process_template('src/build-data/makefile/gmake_coverage.in', vars) \ - if options.build_mode == 'coverage' else '' + if options.with_coverage else '' return vars diff --git a/src/build-data/buildh.in b/src/build-data/buildh.in index 3061c9608..31277ff0c 100644 --- a/src/build-data/buildh.in +++ b/src/build-data/buildh.in @@ -6,7 +6,7 @@ * %{user}@%{hostname} running '%{command_line}' * * Target -* - Compiler: %{cxx} %{lib_opt} +* - Compiler: %{cxx} %{cxx_abi_flags} %{cc_compile_flags} * - Arch: %{submodel}/%{arch} * - OS: %{os} */ diff --git a/src/build-data/cc/clang.txt b/src/build-data/cc/clang.txt index 129218dcd..fd11e59ec 100644 --- a/src/build-data/cc/clang.txt +++ b/src/build-data/cc/clang.txt @@ -13,10 +13,9 @@ lang_flags "-std=c++11 -D_REENTRANT -fstack-protector" warning_flags "-Wall -Wextra -Wstrict-aliasing -Wstrict-overflow=5 -Wcast-align -Wmissing-declarations -Wpointer-arith -Wcast-qual -Wunreachable-code" maintainer_warning_flags "-Qunused-arguments -Werror -Wno-error=unused-parameter -Wno-error=unused-variable -Wno-error=unreachable-code" -compile_flags_release "-c" -compile_flags_debug "-c -g" -lib_opt_flags_release "-O3" -app_opt_flags_release "-O2" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-O3" shared_flags "-fPIC" coverage_flags "--coverage" diff --git a/src/build-data/cc/ekopath.txt b/src/build-data/cc/ekopath.txt index a41abc7c4..549c21a23 100644 --- a/src/build-data/cc/ekopath.txt +++ b/src/build-data/cc/ekopath.txt @@ -7,10 +7,9 @@ add_include_dir_option -I add_lib_dir_option -L add_lib_option -l -compile_flags_release "-c" -compile_flags_debug "-c -g" -lib_opt_flags_release "-O3 -OPT:Ofast:alias=disjoint" -app_opt_flags_release "-O2" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-O3" lang_flags "-D_REENTRANT -ansi -Wno-long-long" warning_flags "-W -Wall" diff --git a/src/build-data/cc/gcc.txt b/src/build-data/cc/gcc.txt index 4eacacef2..3531e9355 100644 --- a/src/build-data/cc/gcc.txt +++ b/src/build-data/cc/gcc.txt @@ -11,12 +11,9 @@ lang_flags "-std=c++11 -D_REENTRANT" maintainer_warning_flags "-Wold-style-cast -Werror -Wno-error=old-style-cast -Wno-error=zero-as-null-pointer-constant -Wno-error=unused-parameter -Wno-error=unused-variable -Wno-error=strict-overflow" warning_flags "-Wall -Wextra -Wstrict-aliasing -Wstrict-overflow=5 -Wcast-align -Wmissing-declarations -Wpointer-arith -Wcast-qual -Wzero-as-null-pointer-constant" -compile_flags_release "-c" -compile_flags_debug "-c -g" -lib_opt_flags_release "-O2" -lib_opt_flags_debug "-O0" -app_opt_flags_release "-O2" -app_opt_flags_debug "-O0" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-O2" shared_flags "-fPIC" coverage_flags "--coverage" diff --git a/src/build-data/cc/hpcc.txt b/src/build-data/cc/hpcc.txt index 2e30995f6..2f2686d10 100644 --- a/src/build-data/cc/hpcc.txt +++ b/src/build-data/cc/hpcc.txt @@ -7,13 +7,12 @@ add_include_dir_option -I add_lib_dir_option -L add_lib_option -l -compile_flags_release "-c" -compile_flags_debug "-c -g" -lib_opt_flags_release "+O2" -app_opt_flags_release "+O2" - lang_flags "-AA -ext +eh -z" -warning_flags "" # +w + +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "+O2" +warning_flags "+w" shared_flags "+Z" makefile_style gmake diff --git a/src/build-data/cc/icc.txt b/src/build-data/cc/icc.txt index f7fdf72be..084d2a4f2 100644 --- a/src/build-data/cc/icc.txt +++ b/src/build-data/cc/icc.txt @@ -7,10 +7,9 @@ add_include_dir_option -I add_lib_dir_option -L add_lib_option -l -compile_flags_release "-c -fomit-frame-pointer" -compile_flags_debug "-c -g" -lib_opt_flags_release "-O2 -ip -unroll" -app_opt_flags_release "-O2" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-O2" lang_flags "-std=c++0x" warning_flags "-w1" diff --git a/src/build-data/cc/msvc.txt b/src/build-data/cc/msvc.txt index 7a35f9648..67e5023aa 100644 --- a/src/build-data/cc/msvc.txt +++ b/src/build-data/cc/msvc.txt @@ -8,10 +8,15 @@ add_include_dir_option "/I" add_lib_dir_option -L add_lib_option "" -compile_flags_release "/nologo /c /bigobj /O2" -compile_flags_debug "/nologo /c /bigobj /Od /Zi /FS /DEBUG" -app_opt_flags_release "/D_CONSOLE" -app_opt_flags_debug "/D_CONSOLE" +compile_flags "/nologo /c" + +optimization_flags "/O2" + +# for debug info in the object file: +#debug_info_flags "/Z7" + +# for using a PDB file: +debug_info_flags "/Zi /FS" lang_flags "/EHs /GR" warning_flags "/W3 /wd4275 /wd4267" @@ -46,6 +51,6 @@ default-debug -> "$(LINKER) /DEBUG" </binary_link_commands> <mach_abi_linking> -all -> "/MD" -all-debug -> "/MDd" +all -> "/MD /bigobj" +all-debug -> "/MDd /bigobj" </mach_abi_linking> diff --git a/src/build-data/cc/pgi.txt b/src/build-data/cc/pgi.txt index ca4b49cd9..06b2f8400 100644 --- a/src/build-data/cc/pgi.txt +++ b/src/build-data/cc/pgi.txt @@ -7,10 +7,9 @@ add_include_dir_option -I add_lib_dir_option -L add_lib_option -l -compile_flags_release "-c" -compile_flags_debug "-c" -lib_opt_flags_release "-fast -Minline" -app_opt_flags_release "-fast" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-fast -Minline" shared_flags "-fPIC" makefile_style gmake diff --git a/src/build-data/cc/sunstudio.txt b/src/build-data/cc/sunstudio.txt index 964c878ff..9ace5107c 100644 --- a/src/build-data/cc/sunstudio.txt +++ b/src/build-data/cc/sunstudio.txt @@ -7,10 +7,9 @@ add_include_dir_option -I add_lib_dir_option -L add_lib_option -l -compile_flags_release "-c" -compile_flags_debug "-c -g" -lib_opt_flags_release "-xO5" -app_opt_flags_release "-xO2" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-xO2" shared_flags "-KPIC" warning_flags "+w -erroff=truncwarn,wnoretvalue" diff --git a/src/build-data/cc/xlc.txt b/src/build-data/cc/xlc.txt index 68dc62582..55b9e7092 100644 --- a/src/build-data/cc/xlc.txt +++ b/src/build-data/cc/xlc.txt @@ -7,10 +7,9 @@ add_include_dir_option -I add_lib_dir_option -L add_lib_option -l -compile_flags_release "-c" -compile_flags_debug "-c -g" -lib_opt_flags_release "-O2" -app_opt_flags_release "-O2" +compile_flags "-c" +debug_info_flags "-g" +optimization_flags "-O2" lang_flags "" diff --git a/src/build-data/makefile/header.in b/src/build-data/makefile/header.in index a83184bb8..eaf4b511d 100644 --- a/src/build-data/makefile/header.in +++ b/src/build-data/makefile/header.in @@ -1,10 +1,9 @@ # Compiler Options -CXX = %{cxx} +CXX = %{cxx} %{cxx_abi_flags} LINKER = %{linker} -LIB_OPT = %{lib_opt} -APP_OPT = %{app_opt} -LANG_FLAGS = %{lang_flags} -WARN_FLAGS = %{warn_flags} + +CXXFLAGS = %{cc_compile_flags} +WARN_FLAGS = %{cc_warning_flags} SO_OBJ_FLAGS = %{shared_flags} LIB_LINK_CMD = %{lib_link_cmd} @@ -15,9 +14,9 @@ LIB_LINKS_TO = %{link_to} APP_LINKS_TO = $(LIB_LINKS_TO) TEST_LINKS_TO = $(LIB_LINKS_TO) -LIB_FLAGS = $(SO_OBJ_FLAGS) $(LANG_FLAGS) $(LIB_OPT) $(WARN_FLAGS) -APP_FLAGS = $(LANG_FLAGS) $(APP_OPT) $(WARN_FLAGS) -TEST_FLAGS = $(LANG_FLAGS) $(APP_OPT) $(WARN_FLAGS) +LIB_FLAGS = $(SO_OBJ_FLAGS) $(CXXFLAGS) $(WARN_FLAGS) +APP_FLAGS = $(CXXFLAGS) $(WARN_FLAGS) +TEST_FLAGS = $(CXXFLAGS) $(WARN_FLAGS) SCRIPTS_DIR = %{scripts_dir} diff --git a/src/scripts/ci/circle/clang-shared-debug.sh b/src/scripts/ci/circle/clang-shared-debug.sh index 2ef4e6dd5..5f38cad7c 100755 --- a/src/scripts/ci/circle/clang-shared-debug.sh +++ b/src/scripts/ci/circle/clang-shared-debug.sh @@ -5,6 +5,6 @@ which shellcheck > /dev/null && shellcheck "$0" # Run shellcheck on this if avai BUILD_NICKNAME=$(basename "$0" .sh) BUILD_DIR="./build-$BUILD_NICKNAME" -./configure.py --with-build-dir="$BUILD_DIR" --build-mode=debug --cc=clang +./configure.py --with-build-dir="$BUILD_DIR" --with-debug-info --cc=clang make -j 2 -f "$BUILD_DIR"/Makefile "$BUILD_DIR"/botan-test diff --git a/src/scripts/ci/circle/clang-static-debug.sh b/src/scripts/ci/circle/clang-static-debug.sh index 6341dd467..56f111190 100755 --- a/src/scripts/ci/circle/clang-static-debug.sh +++ b/src/scripts/ci/circle/clang-static-debug.sh @@ -5,6 +5,6 @@ which shellcheck > /dev/null && shellcheck "$0" # Run shellcheck on this if avai BUILD_NICKNAME=$(basename "$0" .sh) BUILD_DIR="./build-$BUILD_NICKNAME" -./configure.py --with-build-dir="$BUILD_DIR" --build-mode=debug --cc=clang --disable-shared +./configure.py --with-build-dir="$BUILD_DIR" --with-debug-info --cc=clang --disable-shared make -j 2 -f "$BUILD_DIR"/Makefile "$BUILD_DIR"/botan-test diff --git a/src/scripts/ci/circle/gcc-sanitizer.sh b/src/scripts/ci/circle/gcc-sanitizer.sh new file mode 100755 index 000000000..33d474fc6 --- /dev/null +++ b/src/scripts/ci/circle/gcc-sanitizer.sh @@ -0,0 +1,11 @@ +#!/bin/bash +set -ev +which shellcheck > /dev/null && shellcheck "$0" # Run shellcheck on this if available + +BUILD_NICKNAME=$(basename "$0" .sh) +BUILD_DIR="./build-$BUILD_NICKNAME" + +# Adding Ubsan here, only added in GCC 4.9 +./configure.py --with-build-dir="$BUILD_DIR" --with-debug-info --with-sanitizer --cc-abi-flags='-fsanitize=undefined' +make -j 2 -f "$BUILD_DIR"/Makefile +"$BUILD_DIR"/botan-test diff --git a/src/scripts/ci/circle/gcc-shared-debug.sh b/src/scripts/ci/circle/gcc-shared-debug.sh index 93530b8ac..4f5ed1b6d 100755 --- a/src/scripts/ci/circle/gcc-shared-debug.sh +++ b/src/scripts/ci/circle/gcc-shared-debug.sh @@ -5,6 +5,6 @@ which shellcheck > /dev/null && shellcheck "$0" # Run shellcheck on this if avai BUILD_NICKNAME=$(basename "$0" .sh) BUILD_DIR="./build-$BUILD_NICKNAME" -./configure.py --with-build-dir="$BUILD_DIR" --build-mode=debug +./configure.py --with-build-dir="$BUILD_DIR" --with-debug make -j 2 -f "$BUILD_DIR"/Makefile "$BUILD_DIR"/botan-test diff --git a/src/scripts/ci/circle/gcc-static-debug.sh b/src/scripts/ci/circle/gcc-static-debug.sh index c7d23b9b0..76f4c46b7 100755 --- a/src/scripts/ci/circle/gcc-static-debug.sh +++ b/src/scripts/ci/circle/gcc-static-debug.sh @@ -5,6 +5,6 @@ which shellcheck > /dev/null && shellcheck "$0" # Run shellcheck on this if avai BUILD_NICKNAME=$(basename "$0" .sh) BUILD_DIR="./build-$BUILD_NICKNAME" -./configure.py --with-build-dir="$BUILD_DIR" --build-mode=debug --disable-shared --via-amalgamation +./configure.py --with-build-dir="$BUILD_DIR" --with-debug-info --disable-shared --via-amalgamation make -j 2 -f "$BUILD_DIR"/Makefile "$BUILD_DIR"/botan-test diff --git a/src/scripts/ci/travis/build.sh b/src/scripts/ci/travis/build.sh index bb52f0648..092e9cbe6 100755 --- a/src/scripts/ci/travis/build.sh +++ b/src/scripts/ci/travis/build.sh @@ -7,10 +7,9 @@ if [ "$BUILD_MODE" = "static" ]; then elif [ "$BUILD_MODE" = "shared" ]; then CFG_FLAGS=() elif [ "$BUILD_MODE" = "coverage" ]; then - # lcov gets confused by symlinks - CFG_FLAGS=(--build-mode=coverage --link-method=copy) + CFG_FLAGS=(--with-coverage) elif [ "$BUILD_MODE" = "sanitizer" ]; then - CFG_FLAGS=(--build-mode=sanitizer) + CFG_FLAGS=(--with-sanitizer) fi if [ "$MODULES" = "min" ]; then diff --git a/src/tests/test_ffi.cpp b/src/tests/test_ffi.cpp index 75e81de97..ecaa4a27c 100644 --- a/src/tests/test_ffi.cpp +++ b/src/tests/test_ffi.cpp @@ -155,8 +155,7 @@ TEST_CASE("FFI PBKDF", "[ffi]") CHECK(iters_10ms >= 10000); /* - * Tests deactivated due to consistetly failing in debug mode where -W0 is set - * (./configure.py --build-mode=debug). + * Tests deactivated due to consistently failing when optimizations are disabled * See also: https://github.com/randombit/botan/commit/30b0e3c88e94ba04c1843798f7ac74a008e01d9b */ /* |