aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJack Lloyd <[email protected]>2018-07-20 10:53:35 -0400
committerJack Lloyd <[email protected]>2018-07-20 10:53:35 -0400
commit7408f036c376fc34dab497408b4e3e5023846fd3 (patch)
tree6173578d562f6ca55245dce5d2b8515c0f6787dc /src
parent381ee690999318a86fa61a0ac54416230b5567da (diff)
parent0472b6a95fa36257d0bf4ad99a14d437eedaa9ee (diff)
Merge GH #1628 In ECDSA verify, handle error seen with LibreSSL on non-x86
Diffstat (limited to 'src')
-rw-r--r--src/lib/prov/openssl/openssl_ec.cpp23
1 files changed, 16 insertions, 7 deletions
diff --git a/src/lib/prov/openssl/openssl_ec.cpp b/src/lib/prov/openssl/openssl_ec.cpp
index ca5be857a..b9e53b6fd 100644
--- a/src/lib/prov/openssl/openssl_ec.cpp
+++ b/src/lib/prov/openssl/openssl_ec.cpp
@@ -187,15 +187,24 @@ class OpenSSL_ECDSA_Verification_Operation final : public PK_Ops::Verification_w
if(res < 0)
{
int err = ERR_get_error();
+
+ bool hard_error = true;
+
#if defined(EC_R_BAD_SIGNATURE)
- if(ERR_GET_REASON(err) != EC_R_BAD_SIGNATURE)
- throw OpenSSL_Error("ECDSA_do_verify", err);
-#elif defined(ECDSA_R_BAD_SIGNATURE)
- if(ERR_GET_REASON(err) != ECDSA_R_BAD_SIGNATURE)
- throw OpenSSL_Error("ECDSA_do_verify", err);
-#else
- throw OpenSSL_Error("ECDSA_do_verify");
+ if(ERR_GET_REASON(err) == EC_R_BAD_SIGNATURE)
+ hard_error = false;
#endif
+#if defined(EC_R_POINT_AT_INFINITY)
+ if(ERR_GET_REASON(err) == EC_R_POINT_AT_INFINITY)
+ hard_error = false;
+#endif
+#if defined(ECDSA_R_BAD_SIGNATURE)
+ if(ERR_GET_REASON(err) == ECDSA_R_BAD_SIGNATURE)
+ hard_error = false;
+#endif
+
+ if(hard_error)
+ throw OpenSSL_Error("ECDSA_do_verify", err);
}
return (res == 1);
}