The server would incorrectly send a server key exchange message when a

pure RSA ciphersuite was negotiated.

Detection of version rollback attacks with pure RSA ciphersuites was
incorrect and would cause failures if the client supported a version
we didn't (eg GnuTLS with TLS 1.2 enabled).

Improve detection of SSLv2 client hellos. In particular, if a client
that only supports SSLv2 connects, we will detect this case and send a
protocol_version alert (which the SSLv2-only client will not
understand, but a packet analyzer probably will) plus an exception
with the message "Client claims to only support SSLv2, rejecting"
instead of the previous much less helpful "Unknown record type"
message.

Remove vestigial support for RSA export ciphersuite key exchange.

1 files changed, 2 insertions, 1 deletions

diff --git a/src/tls/tls_channel.cpp b/src/tls/tls_channel.cpp
index 6d554e425..a19836395 100644
--- a/src/tls/tls_channel.cpp
+++ b/src/tls/tls_channel.cpp
@@ -49,7 +49,8 @@ size_t TLS_Channel::received_data(const byte buf[], size_t buf_size)
          buf += consumed;
          buf_size -= consumed;
 
-         BOTAN_ASSERT_IMPLICATAION(needed, buf_size == 0);
+         BOTAN_ASSERT(buf_size == 0 || needed == 0,
+                      "Got a full record or consumed all input");
 
          if(buf_size == 0 && needed != 0)
             return needed; // need more data to complete record