diff options
author | lloyd <[email protected]> | 2012-01-19 15:03:07 +0000 |
---|---|---|
committer | lloyd <[email protected]> | 2012-01-19 15:03:07 +0000 |
commit | 30104a60568b392886c1d717a7ca006378552e4d (patch) | |
tree | 2ad36cb3d8ced600d15a85f38ae2f7d9e7a32698 /src/tls/rec_read.cpp | |
parent | b899ee14925310574da400c2af0f491f8cd2a103 (diff) |
I'm not sure if I like this asthetically, but passing around the
entire handshake state in many cases makes things simpler to update,
in that each message type already knows what it needs depending on the
version, params, etc, and this way a) that knowledge doesn't need to
percolate up the the actual client and server handshake code and b)
each message type can be updated for new formats/version without
having to change its callers. Downside is it hides the dependency
information away, and makes it non-obvious what needs to be created
beforehand for each message to work correctly. However this is
(almost) entirely predicated on the handshake message flows, and these
we control with the next expected message scheme, so this should be
fairly safe to do.
This checkin only updates the ones where it was immediately relevant
but for consistency probably all of them should be updated in the same
way.
Diffstat (limited to 'src/tls/rec_read.cpp')
-rw-r--r-- | src/tls/rec_read.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tls/rec_read.cpp b/src/tls/rec_read.cpp index f8e6bab26..20dfaae2e 100644 --- a/src/tls/rec_read.cpp +++ b/src/tls/rec_read.cpp @@ -68,7 +68,7 @@ void Record_Reader::set_version(Version_Code version) * Set the keys for reading */ void Record_Reader::activate(const TLS_Cipher_Suite& suite, - const SessionKeys& keys, + const Session_Keys& keys, Connection_Side side) { m_cipher.reset(); |