Fix clang-tidy readability-named-parameter

30 files changed, 73 insertions, 73 deletions

diff --git a/src/tests/test_bigint.cpp b/src/tests/test_bigint.cpp
index 232cba648..bec9ba14b 100644
--- a/src/tests/test_bigint.cpp
+++ b/src/tests/test_bigint.cpp
@@ -267,7 +267,7 @@ class BigInt_Add_Test final : public Text_Based_Test
    public:
       BigInt_Add_Test() : Text_Based_Test("bn/add.vec", "In1,In2,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Addition");
 
@@ -300,7 +300,7 @@ class BigInt_Sub_Test final : public Text_Based_Test
    public:
       BigInt_Sub_Test() : Text_Based_Test("bn/sub.vec", "In1,In2,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Subtraction");
 
@@ -325,7 +325,7 @@ class BigInt_Mul_Test final : public Text_Based_Test
    public:
       BigInt_Mul_Test() : Text_Based_Test("bn/mul.vec", "In1,In2,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Multiply");
 
@@ -355,7 +355,7 @@ class BigInt_Sqr_Test final : public Text_Based_Test
    public:
       BigInt_Sqr_Test() : Text_Based_Test("bn/sqr.vec", "Input,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Square");
 
@@ -376,7 +376,7 @@ class BigInt_Div_Test final : public Text_Based_Test
    public:
       BigInt_Div_Test() : Text_Based_Test("bn/divide.vec", "In1,In2,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Divide");
 
@@ -418,7 +418,7 @@ class BigInt_Mod_Test final : public Text_Based_Test
    public:
       BigInt_Mod_Test() : Text_Based_Test("bn/mod.vec", "In1,In2,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Mod");
 
@@ -467,7 +467,7 @@ class BigInt_GCD_Test final : public Text_Based_Test
    public:
       BigInt_GCD_Test() : Text_Based_Test("bn/gcd.vec", "X,Y,GCD") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt GCD");
 
@@ -492,7 +492,7 @@ class BigInt_Jacobi_Test final : public Text_Based_Test
    public:
       BigInt_Jacobi_Test() : Text_Based_Test("bn/jacobi.vec", "A,N,J") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Jacobi");
 
@@ -520,7 +520,7 @@ class BigInt_Lshift_Test final : public Text_Based_Test
    public:
       BigInt_Lshift_Test() : Text_Based_Test("bn/lshift.vec", "Value,Shift,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Lshift");
 
@@ -545,7 +545,7 @@ class BigInt_Rshift_Test final : public Text_Based_Test
    public:
       BigInt_Rshift_Test() : Text_Based_Test("bn/rshift.vec", "Value,Shift,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Rshift");
 
@@ -570,7 +570,7 @@ class BigInt_Powmod_Test final : public Text_Based_Test
    public:
       BigInt_Powmod_Test() : Text_Based_Test("bn/powmod.vec", "Base,Exponent,Modulus,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Powmod");
 
@@ -615,7 +615,7 @@ class BigInt_IsSquare_Test final : public Text_Based_Test
    public:
       BigInt_IsSquare_Test() : Text_Based_Test("bn/perfect_square.vec", "X,R") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const BigInt value = vars.get_req_bn("X");
          const BigInt expected = vars.get_req_bn("R");
@@ -634,7 +634,7 @@ class BigInt_Ressol_Test final : public Text_Based_Test
    public:
       BigInt_Ressol_Test() : Text_Based_Test("bn/ressol.vec", "Input,Modulus,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Ressol");
 
@@ -663,7 +663,7 @@ class BigInt_InvMod_Test final : public Text_Based_Test
    public:
       BigInt_InvMod_Test() : Text_Based_Test("bn/invmod.vec", "Input,Modulus,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt InvMod");
 
@@ -697,7 +697,7 @@ class BigInt_Rand_Test final : public Text_Based_Test
    public:
       BigInt_Rand_Test() : Text_Based_Test("bn/random.vec", "Seed,Min,Max,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("BigInt Random");
 
diff --git a/src/tests/test_blowfish.cpp b/src/tests/test_blowfish.cpp
index c4c0bfe65..3df320844 100644
--- a/src/tests/test_blowfish.cpp
+++ b/src/tests/test_blowfish.cpp
@@ -17,7 +17,7 @@ class Blowfish_Salted_Tests final : public Text_Based_Test
    public:
       Blowfish_Salted_Tests() : Text_Based_Test("salted_blowfish.vec", "Key,Salt,Out") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("Blowfish salted key schedule");
 
diff --git a/src/tests/test_c25519.cpp b/src/tests/test_c25519.cpp
index 4bf59e7ce..6f3bcf961 100644
--- a/src/tests/test_c25519.cpp
+++ b/src/tests/test_c25519.cpp
@@ -25,7 +25,7 @@ class Curve25519_Sclarmult_Tests final : public Text_Based_Test
             "pubkey/c25519_scalar.vec",
             "Secret,Basepoint,Out") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const std::vector<uint8_t> secret    = vars.get_req_bin("Secret");
          const std::vector<uint8_t> basepoint = vars.get_req_bin("Basepoint");
@@ -49,12 +49,12 @@ class Curve25519_Agreement_Tests final : public PK_Key_Agreement_Test
          "pubkey/x25519.vec",
          "Secret,CounterKey,K") {}
 
-      std::string default_kdf(const VarMap&) const override
+      std::string default_kdf(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
 
-      std::unique_ptr<Botan::Private_Key> load_our_key(const std::string&,
+      std::unique_ptr<Botan::Private_Key> load_our_key(const std::string& /*header*/,
                                                        const VarMap& vars) override
          {
          const std::vector<uint8_t> secret_vec = vars.get_req_bin("Secret");
@@ -62,7 +62,7 @@ class Curve25519_Agreement_Tests final : public PK_Key_Agreement_Test
          return std::make_unique<Botan::Curve25519_PrivateKey>(secret);
          }
 
-      std::vector<uint8_t> load_their_key(const std::string&, const VarMap& vars) override
+      std::vector<uint8_t> load_their_key(const std::string& /*header*/, const VarMap& vars) override
          {
          return vars.get_req_bin("CounterKey");
          }
diff --git a/src/tests/test_cryptobox.cpp b/src/tests/test_cryptobox.cpp
index ce161d1c2..88acf9d2b 100644
--- a/src/tests/test_cryptobox.cpp
+++ b/src/tests/test_cryptobox.cpp
@@ -23,7 +23,7 @@ class Cryptobox_KAT final : public Text_Based_Test
    public:
       Cryptobox_KAT() : Text_Based_Test("cryptobox.vec", "Input,Passphrase,Salt,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("Cryptobox");
 
diff --git a/src/tests/test_dh.cpp b/src/tests/test_dh.cpp
index 73abb281a..4e47157e4 100644
--- a/src/tests/test_dh.cpp
+++ b/src/tests/test_dh.cpp
@@ -28,12 +28,12 @@ class Diffie_Hellman_KAT_Tests final : public PK_Key_Agreement_Test
               "P,G,X,Y,K",
               "Q,KDF,OutLen") {}
 
-      std::string default_kdf(const VarMap&) const override
+      std::string default_kdf(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
 
-      std::unique_ptr<Botan::Private_Key> load_our_key(const std::string&, const VarMap& vars) override
+      std::unique_ptr<Botan::Private_Key> load_our_key(const std::string& /*header*/, const VarMap& vars) override
          {
          const Botan::BigInt p = vars.get_req_bn("P");
          const Botan::BigInt q = vars.get_opt_bn("Q", 0);
@@ -53,7 +53,7 @@ class Diffie_Hellman_KAT_Tests final : public PK_Key_Agreement_Test
          return std::make_unique<Botan::DH_PrivateKey>(Test::rng(), grp, x);
          }
 
-      std::vector<uint8_t> load_their_key(const std::string&, const VarMap& vars) override
+      std::vector<uint8_t> load_their_key(const std::string& /*header*/, const VarMap& vars) override
          {
          const Botan::BigInt p = vars.get_req_bn("P");
          const Botan::BigInt q = vars.get_opt_bn("Q", 0);
@@ -119,7 +119,7 @@ class DH_Invalid_Key_Tests final : public Text_Based_Test
          return false;
          }
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("DH invalid keys");
 
diff --git a/src/tests/test_dsa.cpp b/src/tests/test_dsa.cpp
index afca161bb..4bccea7ac 100644
--- a/src/tests/test_dsa.cpp
+++ b/src/tests/test_dsa.cpp
@@ -79,7 +79,7 @@ class DSA_Verification_Tests final : public PK_Signature_Verification_Test
          return std::make_unique<Botan::DSA_PublicKey>(grp, y);
          }
 
-      std::string default_padding(const VarMap&) const override
+      std::string default_padding(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
diff --git a/src/tests/test_ec_group.cpp b/src/tests/test_ec_group.cpp
index 800012e98..2ad107b98 100644
--- a/src/tests/test_ec_group.cpp
+++ b/src/tests/test_ec_group.cpp
@@ -819,7 +819,7 @@ class ECC_Invalid_Key_Tests final : public Text_Based_Test
          return false;
          }
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("ECC invalid keys");
 
diff --git a/src/tests/test_ecdh.cpp b/src/tests/test_ecdh.cpp
index 3f373e6bd..ed880d81e 100644
--- a/src/tests/test_ecdh.cpp
+++ b/src/tests/test_ecdh.cpp
@@ -27,7 +27,7 @@ class ECDH_KAT_Tests final : public PK_Key_Agreement_Test
               "Secret,CounterKey,K",
               "KDF") {}
 
-      std::string default_kdf(const VarMap&) const override
+      std::string default_kdf(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
@@ -40,7 +40,7 @@ class ECDH_KAT_Tests final : public PK_Key_Agreement_Test
          return std::make_unique<Botan::ECDH_PrivateKey>(Test::rng(), group, secret);
          }
 
-      std::vector<uint8_t> load_their_key(const std::string&, const VarMap& vars) override
+      std::vector<uint8_t> load_their_key(const std::string& /*header*/, const VarMap& vars) override
          {
          return vars.get_req_bin("CounterKey");
          }
diff --git a/src/tests/test_ecdsa.cpp b/src/tests/test_ecdsa.cpp
index f7f5afc12..5069af812 100644
--- a/src/tests/test_ecdsa.cpp
+++ b/src/tests/test_ecdsa.cpp
@@ -47,7 +47,7 @@ class ECDSA_Verification_Tests final : public PK_Signature_Verification_Test
          return std::make_unique<Botan::ECDSA_PublicKey>(group, public_point);
          }
 
-      std::string default_padding(const VarMap&) const override
+      std::string default_padding(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
@@ -170,7 +170,7 @@ class ECDSA_Key_Recovery_Tests final : public Text_Based_Test
       ECDSA_Key_Recovery_Tests() :
          Text_Based_Test("pubkey/ecdsa_key_recovery.vec", "Group,Msg,R,S,V,PubkeyX,PubkeyY") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("ECDSA key recovery");
 
@@ -223,7 +223,7 @@ class ECDSA_Invalid_Key_Tests final : public Text_Based_Test
          return false;
          }
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("ECDSA invalid keys");
 
diff --git a/src/tests/test_ecies.cpp b/src/tests/test_ecies.cpp
index a21c5ce8f..3a89b0550 100644
--- a/src/tests/test_ecies.cpp
+++ b/src/tests/test_ecies.cpp
@@ -107,7 +107,7 @@ class ECIES_ISO_Tests final : public Text_Based_Test
             "pubkey/ecies-18033.vec",
             "format,p,a,b,mu,nu,gx,gy,hx,hy,x,r,C0,K") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("ECIES-ISO");
 
@@ -200,7 +200,7 @@ class ECIES_Tests final : public Text_Based_Test
               "CofactorMode,OldCofactorMode,CheckMode,SingleHashMode,Label,Plaintext,Ciphertext",
               "Iv") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("ECIES");
 
diff --git a/src/tests/test_fpe.cpp b/src/tests/test_fpe.cpp
index 146361e06..0cce35eda 100644
--- a/src/tests/test_fpe.cpp
+++ b/src/tests/test_fpe.cpp
@@ -19,7 +19,7 @@ class FPE_FE1_Tests final : public Text_Based_Test
    public:
       FPE_FE1_Tests() : Text_Based_Test("fpe_fe1.vec", "Mod,In,Out,Key,Tweak") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const Botan::BigInt modulus  = vars.get_req_bn("Mod");
          const Botan::BigInt input    = vars.get_req_bn("In");
diff --git a/src/tests/test_keywrap.cpp b/src/tests/test_keywrap.cpp
index d05a0baa6..83ae87cec 100644
--- a/src/tests/test_keywrap.cpp
+++ b/src/tests/test_keywrap.cpp
@@ -25,7 +25,7 @@ class RFC3394_Keywrap_Tests final : public Text_Based_Test
    public:
       RFC3394_Keywrap_Tests() : Text_Based_Test("keywrap/rfc3394.vec", "Key,KEK,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("RFC3394 keywrap");
 
diff --git a/src/tests/test_mceliece.cpp b/src/tests/test_mceliece.cpp
index 900f7a706..66605c06d 100644
--- a/src/tests/test_mceliece.cpp
+++ b/src/tests/test_mceliece.cpp
@@ -38,7 +38,7 @@ class McEliece_Keygen_Encrypt_Test final : public Text_Based_Test
                            "EncryptPRNGSeed,SharedKey,Ciphertext",
                            "") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const std::vector<uint8_t> keygen_seed  = vars.get_req_bin("McElieceSeed");
          const std::vector<uint8_t> fprint_pub   = vars.get_req_bin("PublicKeyFingerprint");
diff --git a/src/tests/test_newhope.cpp b/src/tests/test_newhope.cpp
index e60e84e9e..14e4a0190 100644
--- a/src/tests/test_newhope.cpp
+++ b/src/tests/test_newhope.cpp
@@ -73,7 +73,7 @@ class NEWHOPE_RNG final : public Botan::RandomNumberGenerator
 
       bool accepts_input() const override { return false; }
 
-      void add_entropy(const uint8_t[], size_t) override
+      void add_entropy(const uint8_t /*input*/[], size_t /*length*/) override
          {
          /* ignored */
          }
@@ -112,7 +112,7 @@ class NEWHOPE_Tests final : public Text_Based_Test
               "pubkey/newhope.vec",
               "DRBG_SeedA,H_OutputA,DRBG_SeedB,H_OutputB,SharedKey") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("NEWHOPE");
 
diff --git a/src/tests/test_ocb.cpp b/src/tests/test_ocb.cpp
index 21e6e330d..6c13e851e 100644
--- a/src/tests/test_ocb.cpp
+++ b/src/tests/test_ocb.cpp
@@ -117,7 +117,7 @@ class OCB_Wide_KAT_Tests final : public Text_Based_Test
       OCB_Wide_KAT_Tests()
          : Text_Based_Test("ocb/ocb_wide.vec", "Key,Nonce,AD,In,Out") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("OCB wide block KAT");
 
@@ -274,7 +274,7 @@ class OCB_Long_KAT_Tests final : public Text_Based_Test
          : Text_Based_Test("ocb/ocb_long.vec",
                            "Keylen,Taglen,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const size_t keylen = vars.get_req_sz("Keylen");
          const size_t taglen = vars.get_req_sz("Taglen");
diff --git a/src/tests/test_passhash.cpp b/src/tests/test_passhash.cpp
index dc1d275a4..7d6125287 100644
--- a/src/tests/test_passhash.cpp
+++ b/src/tests/test_passhash.cpp
@@ -29,7 +29,7 @@ class Bcrypt_Tests final : public Text_Based_Test
    public:
       Bcrypt_Tests() : Text_Based_Test("passhash/bcrypt.vec", "Password,Passhash") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          // Encoded as binary so we can test binary inputs
          const std::vector<uint8_t> password_vec = vars.get_req_bin("Password");
@@ -135,7 +135,7 @@ class Passhash9_Tests final : public Text_Based_Test
    public:
       Passhash9_Tests() : Text_Based_Test("passhash/passhash9.vec", "Password,Passhash,PRF") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          // Encoded as binary so we can test binary inputs
          const std::vector<uint8_t> password_vec = vars.get_req_bin("Password");
diff --git a/src/tests/test_pbkdf.cpp b/src/tests/test_pbkdf.cpp
index bad598da9..d6b242fe3 100644
--- a/src/tests/test_pbkdf.cpp
+++ b/src/tests/test_pbkdf.cpp
@@ -159,7 +159,7 @@ class Bcrypt_PBKDF_KAT_Tests final : public Text_Based_Test
    public:
       Bcrypt_PBKDF_KAT_Tests() : Text_Based_Test("bcrypt_pbkdf.vec", "Passphrase,Salt,Iterations,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const size_t rounds = vars.get_req_sz("Iterations");
          const std::vector<uint8_t> salt = vars.get_req_bin("Salt");
@@ -201,7 +201,7 @@ class Scrypt_KAT_Tests final : public Text_Based_Test
    public:
       Scrypt_KAT_Tests() : Text_Based_Test("scrypt.vec", "Passphrase,Salt,N,R,P,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const size_t N = vars.get_req_sz("N");
          const size_t R = vars.get_req_sz("R");
diff --git a/src/tests/test_pkcs11_low_level.cpp b/src/tests/test_pkcs11_low_level.cpp
index a88ddd2dc..bbf3816d8 100644
--- a/src/tests/test_pkcs11_low_level.cpp
+++ b/src/tests/test_pkcs11_low_level.cpp
@@ -154,7 +154,7 @@ class RAII_LowLevel
       bool m_is_logged_in;
    };
 
-bool no_op(ReturnValue*)
+bool no_op(ReturnValue* /*unused*/)
    {
    return true;
    }
diff --git a/src/tests/test_pubkey.cpp b/src/tests/test_pubkey.cpp
index 85d9d425f..3e69764c9 100644
--- a/src/tests/test_pubkey.cpp
+++ b/src/tests/test_pubkey.cpp
@@ -493,7 +493,7 @@ PK_Decryption_Test::run_one_test(const std::string& pad_hdr, const VarMap& vars)
    return result;
    }
 
-Test::Result PK_KEM_Test::run_one_test(const std::string&, const VarMap& vars)
+Test::Result PK_KEM_Test::run_one_test(const std::string& /*header*/, const VarMap& vars)
    {
    const std::vector<uint8_t> K = vars.get_req_bin("K");
    const std::vector<uint8_t> C0 = vars.get_req_bin("C0");
diff --git a/src/tests/test_rng.cpp b/src/tests/test_rng.cpp
index deebea37e..4273f5c4b 100644
--- a/src/tests/test_rng.cpp
+++ b/src/tests/test_rng.cpp
@@ -160,7 +160,7 @@ class Stateful_RNG_Tests : public Test
                   return "Broken Entropy Source";
                   }
 
-               size_t poll(Botan::RandomNumberGenerator&) override
+               size_t poll(Botan::RandomNumberGenerator& /*rng*/) override
                   {
                   throw Botan::Not_Implemented("polling not available");
                   }
@@ -174,7 +174,7 @@ class Stateful_RNG_Tests : public Test
                   return "Insufficient Entropy Source";
                   }
 
-               size_t poll(Botan::RandomNumberGenerator&) override
+               size_t poll(Botan::RandomNumberGenerator& /*rng*/) override
                   {
                   return 0;
                   }
diff --git a/src/tests/test_rng_kat.cpp b/src/tests/test_rng_kat.cpp
index 8aa20101c..e38c9a3cb 100644
--- a/src/tests/test_rng_kat.cpp
+++ b/src/tests/test_rng_kat.cpp
@@ -79,7 +79,7 @@ class ChaCha_RNG_Tests final : public Text_Based_Test
                            "EntropyInput,EntropyInputReseed,Out",
                            "AdditionalInput1,AdditionalInput2") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const std::vector<uint8_t> seed_input   = vars.get_req_bin("EntropyInput");
          const std::vector<uint8_t> reseed_input = vars.get_req_bin("EntropyInputReseed");
diff --git a/src/tests/test_rsa.cpp b/src/tests/test_rsa.cpp
index 65124e063..a127f4148 100644
--- a/src/tests/test_rsa.cpp
+++ b/src/tests/test_rsa.cpp
@@ -96,7 +96,7 @@ class RSA_Signature_KAT_Tests final : public PK_Signature_Generation_Test
               "E,P,Q,Msg,Signature",
               "Nonce") {}
 
-      std::string default_padding(const VarMap&) const override
+      std::string default_padding(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
@@ -172,7 +172,7 @@ class RSA_Signature_Verify_Tests final : public PK_Signature_Verification_Test
               "pubkey/rsa_verify.vec",
               "E,N,Msg,Signature") {}
 
-      std::string default_padding(const VarMap&) const override
+      std::string default_padding(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
@@ -192,7 +192,7 @@ class RSA_Signature_Verify_Invalid_Tests final : public PK_Signature_NonVerifica
               "pubkey/rsa_invalid.vec",
               "E,N,Msg,InvalidSignature") {}
 
-      std::string default_padding(const VarMap&) const override
+      std::string default_padding(const VarMap& /*unused*/) const override
          {
          return "Raw";
          }
diff --git a/src/tests/test_srp6.cpp b/src/tests/test_srp6.cpp
index 08d9b9abf..cb1b64385 100644
--- a/src/tests/test_srp6.cpp
+++ b/src/tests/test_srp6.cpp
@@ -26,7 +26,7 @@ class SRP6_KAT_Tests final : public Text_Based_Test
 
       bool clear_between_callbacks() const override { return false; }
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("SRP6a");
 
diff --git a/src/tests/test_tls.cpp b/src/tests/test_tls.cpp
index d22b118a2..750dacafe 100644
--- a/src/tests/test_tls.cpp
+++ b/src/tests/test_tls.cpp
@@ -114,7 +114,7 @@ class TLS_CBC_Padding_Tests final : public Text_Based_Test
    public:
       TLS_CBC_Padding_Tests() : Text_Based_Test("tls_cbc_padding.vec", "Record,Output") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const std::vector<uint8_t> record    = vars.get_req_bin("Record");
          const size_t output = vars.get_req_sz("Output");
@@ -143,7 +143,7 @@ class TLS_CBC_Tests final : public Text_Based_Test
             std::string name() const override { return "ZeroMac"; }
             size_t output_length() const override { return m_mac_len; }
 
-            void add_data(const uint8_t[], size_t) override {}
+            void add_data(const uint8_t /*input*/[], size_t /*length*/) override {}
 
             void final_result(uint8_t out[]) override
                {
@@ -162,7 +162,7 @@ class TLS_CBC_Tests final : public Text_Based_Test
                }
 
          private:
-            void key_schedule(const uint8_t[], size_t) override {}
+            void key_schedule(const uint8_t /*key*/[], size_t /*length*/) override {}
 
             size_t m_mac_len;
          };
@@ -196,14 +196,14 @@ class TLS_CBC_Tests final : public Text_Based_Test
                return std::make_unique<Noop_Block_Cipher>(m_bs);
                }
          private:
-            void key_schedule(const uint8_t[], size_t) override {}
+            void key_schedule(const uint8_t /*key*/[], size_t /*length*/) override {}
 
             size_t m_bs;
          };
 
       TLS_CBC_Tests() : Text_Based_Test("tls_cbc.vec", "Blocksize,MACsize,Record,Valid") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("TLS CBC");
 
diff --git a/src/tests/test_tss.cpp b/src/tests/test_tss.cpp
index 99dc4f0b5..9acea1b67 100644
--- a/src/tests/test_tss.cpp
+++ b/src/tests/test_tss.cpp
@@ -98,7 +98,7 @@ class TSS_Generation_Tests final : public Text_Based_Test
             throw Test_Error("Unknown TSS hash algorithm " + hash);
          }
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("TSS");
 
diff --git a/src/tests/test_utils.cpp b/src/tests/test_utils.cpp
index 0923c1b0c..cb0ab23f5 100644
--- a/src/tests/test_utils.cpp
+++ b/src/tests/test_utils.cpp
@@ -366,7 +366,7 @@ class Poly_Double_Tests final : public Text_Based_Test
    public:
       Poly_Double_Tests() : Text_Based_Test("poly_dbl.vec", "In,Out") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          Test::Result result("Polynomial doubling");
          const std::vector<uint8_t> in  = vars.get_req_bin("In");
@@ -749,7 +749,7 @@ class UUID_Tests : public Test
 
                std::string name() const override { return "zeros"; }
                bool accepts_input() const override { return false; }
-               void add_entropy(const uint8_t[], size_t) override {}
+               void add_entropy(const uint8_t /*input*/[], size_t /*length*/) override {}
                void clear() override {}
                bool is_seeded() const override { return true; }
             private:
diff --git a/src/tests/test_xmss.cpp b/src/tests/test_xmss.cpp
index fd4b01032..b1d112ca5 100644
--- a/src/tests/test_xmss.cpp
+++ b/src/tests/test_xmss.cpp
@@ -29,7 +29,7 @@ class XMSS_Signature_Tests final : public PK_Signature_Generation_Test
               "pubkey/xmss_sig.vec",
               "Params,Msg,PrivateKey,Signature") {}
 
-      bool skip_this_test(const std::string&,
+      bool skip_this_test(const std::string& /*header*/,
                           const VarMap& vars) override
          {
          if(Test::run_long_tests() == false)
diff --git a/src/tests/test_zfec.cpp b/src/tests/test_zfec.cpp
index f4b9b8335..fdf63c28a 100644
--- a/src/tests/test_zfec.cpp
+++ b/src/tests/test_zfec.cpp
@@ -17,7 +17,7 @@ class ZFEC_KAT final : public Text_Based_Test
    public:
       ZFEC_KAT() : Text_Based_Test("zfec.vec", "K,N,Data,Code") {}
 
-      Test::Result run_one_test(const std::string&, const VarMap& vars) override
+      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override
          {
          const size_t K = vars.get_req_sz("K");
          const size_t N = vars.get_req_sz("N");
diff --git a/src/tests/tests.cpp b/src/tests/tests.cpp
index d8454c4ac..17785c4a2 100644
--- a/src/tests/tests.cpp
+++ b/src/tests/tests.cpp
@@ -394,7 +394,7 @@ bool Test::Result::test_rc(const std::string& func, int expected, int rc)
    return test_success();
    }
 
-std::vector<std::string> Test::possible_providers(const std::string&)
+std::vector<std::string> Test::possible_providers(const std::string& /*unused*/)
    {
    return Test::provider_filter({ "base" });
    }
diff --git a/src/tests/unit_tls.cpp b/src/tests/unit_tls.cpp
index 3061f9119..7e0339451 100644
--- a/src/tests/unit_tls.cpp
+++ b/src/tests/unit_tls.cpp
@@ -69,8 +69,8 @@ class Credentials_Manager_Test final : public Botan::Credentials_Manager
          }
 
       std::vector<Botan::Certificate_Store*>
-      trusted_certificate_authorities(const std::string&,
-                                      const std::string&) override
+      trusted_certificate_authorities(const std::string& /*type*/,
+                                      const std::string& /*context*/) override
          {
          std::vector<Botan::Certificate_Store*> v;
          for(auto const& store : m_stores)
@@ -115,8 +115,8 @@ class Credentials_Manager_Test final : public Botan::Credentials_Manager
          }
 
       Botan::Private_Key* private_key_for(const Botan::X509_Certificate& crt,
-                                          const std::string&,
-                                          const std::string&) override
+                                          const std::string& /*type*/,
+                                          const std::string& /*context*/) override
          {
          if(crt == m_rsa_cert)
             {
@@ -131,7 +131,7 @@ class Credentials_Manager_Test final : public Botan::Credentials_Manager
 
       Botan::SymmetricKey psk(const std::string& type,
                               const std::string& context,
-                              const std::string&) override
+                              const std::string& /*identity*/) override
          {
          if(type == "tls-server" && context == "session-ticket")
             {
@@ -276,7 +276,7 @@ class TLS_Handshake_Test final
 
             Botan::TLS::Handshake_Extension_Type type() const override { return static_type(); }
 
-            std::vector<uint8_t> serialize(Botan::TLS::Connection_Side) const override { return m_buf; }
+            std::vector<uint8_t> serialize(Botan::TLS::Connection_Side /*whoami*/) const override { return m_buf; }
 
             const std::vector<uint8_t>& value() const { return m_buf; }
 
@@ -608,7 +608,7 @@ class Test_Policy final : public Botan::TLS::Text_Policy
    {
    public:
       Test_Policy() : Text_Policy("") {}
-      bool acceptable_protocol_version(Botan::TLS::Protocol_Version) const override
+      bool acceptable_protocol_version(Botan::TLS::Protocol_Version /*version*/) const override
          {
          return true;
          }
@@ -976,7 +976,7 @@ class DTLS_Reconnection_Test : public Test
             public:
                Botan::SymmetricKey psk(const std::string& type,
                                        const std::string& context,
-                                       const std::string&) override
+                                       const std::string& /*identity*/) override
                   {
                   if(type == "tls-server" && context == "session-ticket")
                      {