Moves UBSAN macros from test files to Test_Options

To keep the code more readable change the behavior of
`Test_Options::no_avoid_undefined_behavior()`, instead of the conditionals
inside the tests.

`Test_Options::no_avoid_undefined_behavior()` will always return `true` if
UBSAN is inactive. This way all tests, including those that cause undefined
behaviour, will run. Once botan is compiled with UBSAN those tests will
be automatically skipped unless the `--no-avoid-undefined` is passed to the
test-bench.

1 files changed, 0 insertions, 4 deletions

diff --git a/src/tests/test_ffi.cpp b/src/tests/test_ffi.cpp
index 0d831f251..d5627a45f 100644
--- a/src/tests/test_ffi.cpp
+++ b/src/tests/test_ffi.cpp
@@ -842,18 +842,14 @@ class FFI_Unit_Tests final : public Test
          // delete of null is ok/ignored
          TEST_FFI_RC(0, botan_hash_destroy, (nullptr));
 
-#if defined(BOTAN_HAS_SANITIZER_UNDEFINED)
          if(Test::no_avoid_undefined_behavior())
             {
-#endif
             // Confirm that botan_x_destroy checks the argument type
             botan_mp_t mp;
             botan_mp_init(&mp);
             TEST_FFI_RC(BOTAN_FFI_ERROR_INVALID_OBJECT, botan_hash_destroy, (reinterpret_cast<botan_hash_t>(mp)));
             TEST_FFI_RC(0, botan_mp_destroy, (mp));
-#if defined(BOTAN_HAS_SANITIZER_UNDEFINED)
             }
-#endif
 
          return result;
          }