diff options
author | Jack Lloyd <[email protected]> | 2017-08-31 11:17:18 -0400 |
---|---|---|
committer | Jack Lloyd <[email protected]> | 2017-08-31 11:17:18 -0400 |
commit | c35727e813a9434c351f0a7ffb28ff67452001fb (patch) | |
tree | c0fb352f9a4f2eb54a51f443ada6b94cf5f1f2ec /src/scripts/test_fuzzers.py | |
parent | 8eca2f77562d73f2170f48903316652538f65a35 (diff) |
Use multiprocessing in the fuzzer test script
Improved performance from ~48 seconds to ~10 seconds on my machine.
Diffstat (limited to 'src/scripts/test_fuzzers.py')
-rwxr-xr-x | src/scripts/test_fuzzers.py | 66 |
1 files changed, 37 insertions, 29 deletions
diff --git a/src/scripts/test_fuzzers.py b/src/scripts/test_fuzzers.py index 9b813f013..b00ef0405 100755 --- a/src/scripts/test_fuzzers.py +++ b/src/scripts/test_fuzzers.py @@ -1,35 +1,40 @@ #!/usr/bin/python +# (C) 2017 Jack Lloyd + import sys import os import subprocess import optparse import stat +import multiprocessing + +def run_fuzzer_gdb(args): + (fuzzer_bin, corpus_file) = args -def run_fuzzer(fuzzer_bin, corpus_file, run_under_gdb): + gdb_proc = subprocess.Popen(['gdb', '--quiet', '--return-child-result', fuzzer_bin], + stdin=subprocess.PIPE, + stdout=subprocess.PIPE, + stderr=subprocess.PIPE, + close_fds=True) - if run_under_gdb: - gdb_proc = subprocess.Popen(['gdb', '--quiet', '--return-child-result', fuzzer_bin], - stdin=subprocess.PIPE, - stdout=subprocess.PIPE, - stderr=subprocess.PIPE, - close_fds=True) + gdb_commands = ('run < %s\nbt\nquit\n' % (corpus_file)).encode('ascii') - gdb_commands = ('run < %s\nbt\nquit\n' % (corpus_file)).encode('ascii') + (stdout, stderr) = gdb_proc.communicate(gdb_commands) - (stdout, stderr) = gdb_proc.communicate(gdb_commands) + if gdb_proc.returncode == 0: + return (0, '', '') - if gdb_proc.returncode == 0: - return (0, '', '') + return (corpus_file, gdb_proc.returncode, stdout.decode('ascii'), stderr.decode('ascii')) - return (gdb_proc.returncode, stdout.decode('ascii'), stderr.decode('ascii')) - else: - corpus_fd = open(corpus_file, 'r') - fuzzer_proc = subprocess.Popen([fuzzer_bin], stdin=corpus_fd, - stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) - (stdout, stderr) = fuzzer_proc.communicate() - corpus_fd.close() - return (fuzzer_proc.returncode, stdout.decode('ascii'), stderr.decode('ascii')) +def run_fuzzer(args): + (fuzzer_bin, corpus_file) = args + corpus_fd = open(corpus_file, 'r') + fuzzer_proc = subprocess.Popen([fuzzer_bin], stdin=corpus_fd, + stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) + (stdout, stderr) = fuzzer_proc.communicate() + corpus_fd.close() + return (corpus_file, fuzzer_proc.returncode, stdout.decode('ascii'), stderr.decode('ascii')) def main(args=None): if args is None: @@ -92,19 +97,22 @@ def main(args=None): gdb_commands = None - for f in sorted(list(fuzzers_with_corpus)): - fuzzer_bin = os.path.join(fuzzer_dir, f) - corpus_files = os.path.join(corpus_dir, f) + pool = multiprocessing.Pool(None) + chunk_size = 32 # arbitrary - tests_for_this_fuzzer = 0 + run_fuzzer_func = run_fuzzer_gdb if options.gdb else run_fuzzer - for corpus_file in sorted(list(os.listdir(corpus_files))): - - tests_for_this_fuzzer += 1 + for f in sorted(list(fuzzers_with_corpus)): + fuzzer_bin = os.path.join(fuzzer_dir, f) + corpus_subdir = os.path.join(corpus_dir, f) + corpus_files = [os.path.join(corpus_subdir, l) for l in sorted(list(os.listdir(corpus_subdir)))] - corpus_full_path = os.path.join(corpus_files, corpus_file) + # We have to do this hack because multiprocessing's Pool.map doesn't support + # passing any initial arguments, just the single iteratable + map_args = [(fuzzer_bin, f) for f in corpus_files] - (retcode, stdout, stderr) = run_fuzzer(fuzzer_bin, corpus_full_path, options.gdb) + for result in pool.map(run_fuzzer_func, map_args, chunk_size): + (corpus_file, retcode, stdout, stderr) = result if retcode != 0: print("Fuzzer %s crashed with input %s returncode %d" % (f, corpus_file, retcode)) @@ -118,7 +126,7 @@ def main(args=None): print("Fuzzer %s produced stderr on input %s:\n%s" % (f, corpus_file, stderr)) stderr_count += 1 - print("Tested fuzzer %s with %d test cases, %d crashes" % (f, tests_for_this_fuzzer, crash_count)) + print("Tested fuzzer %s with %d test cases, %d crashes" % (f, len(corpus_files), crash_count)) sys.stdout.flush() if crash_count > 0 or stderr_count > 0 or stdout_count > 0: |