Big, invasive but mostly automated change, with a further attempt at

harmonising MemoryRegion with std::vector:

The MemoryRegion::clear() function would zeroise the buffer, but keep
the memory allocated and the size unchanged. This is very different
from STL's clear(), which is basically the equivalent to what is
called destroy() in MemoryRegion. So to be able to replace MemoryRegion
with a std::vector, we have to rename destroy() to clear() and we have
to expose the current functionality of clear() in some other way, since
vector doesn't support this operation. Do so by adding a global function
named zeroise() which takes a MemoryRegion which is zeroed. Remove clear()
to ensure all callers are updated.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/rng/hmac_rng/hmac_rng.cpp b/src/rng/hmac_rng/hmac_rng.cpp
index fbfa87f70..b9bd65ae1 100644
--- a/src/rng/hmac_rng/hmac_rng.cpp
+++ b/src/rng/hmac_rng/hmac_rng.cpp
@@ -107,7 +107,7 @@ void HMAC_RNG::reseed(u32bit poll_bits)
    extractor->set_key(K, K.size());
 
    // Reset state
-   K.clear();
+   zeroise(K);
    counter = 0;
    user_input_len = 0;
 
@@ -147,7 +147,7 @@ void HMAC_RNG::clear()
    {
    extractor->clear();
    prf->clear();
-   K.clear();
+   zeroise(K);
    counter = 0;
    user_input_len = 0;
    seeded = false;