Make set_all_values in {ECDSA,ECKAEG}_{Public,Private}Key all non-virtual;

virtual-ness not needed, and was overriding/overloading by argument which
doesn't actually work in C++ and only happened to work because it was only
ever used with the version implemented in that same class. ICC was warning,
too. Make non-virtual.

1 files changed, 4 insertions, 3 deletions

diff --git a/src/pubkey/eckaeg/eckaeg.h b/src/pubkey/eckaeg/eckaeg.h
index 31b65740c..7c4dfdb2d 100644
--- a/src/pubkey/eckaeg/eckaeg.h
+++ b/src/pubkey/eckaeg/eckaeg.h
@@ -68,9 +68,10 @@ class BOTAN_DLL ECKAEG_PublicKey : public virtual EC_PublicKey
 
    protected:
       void X509_load_hook();
-      virtual void set_all_values(const ECKAEG_PublicKey& other);
 
       ECKAEG_Core m_eckaeg_core;
+   private:
+      void set_all_values(const ECKAEG_PublicKey& other);
    };
 
 /**
@@ -128,8 +129,8 @@ class BOTAN_DLL ECKAEG_PrivateKey : public ECKAEG_PublicKey,
       */
       virtual void affirm_init() const;
 
-   protected:
-      virtual void set_all_values(const ECKAEG_PrivateKey& other);
+   private:
+      void set_all_values(const ECKAEG_PrivateKey& other);
    };
 
 }