KeyPair::check_key's behavior of throwing an exception upon failure was

not useful; in all cases, we immediately caught it and then returned
false.

Modify as follows:

 - Create the pubkey objects inside the checking code, so calling code
   doesn't need to do it.

 - Return true/false for pass/fail

Also add consistency checking for ECDSA keys

1 files changed, 1 insertions, 12 deletions

diff --git a/src/pubkey/dsa/dsa.cpp b/src/pubkey/dsa/dsa.cpp
index 7f0ab0bfa..7eefa5923 100644
--- a/src/pubkey/dsa/dsa.cpp
+++ b/src/pubkey/dsa/dsa.cpp
@@ -62,18 +62,7 @@ bool DSA_PrivateKey::check_key(RandomNumberGenerator& rng, bool strong) const
    if(!strong)
       return true;
 
-   try
-      {
-      PK_Signer this_signer(*this, "EMSA1(SHA-1)");
-      PK_Verifier this_verifier(*this, "EMSA1(SHA-1)");
-      KeyPair::check_key(rng, this_signer, this_verifier);
-      }
-   catch(Self_Test_Failure)
-      {
-      return false;
-      }
-
-   return true;
+   return KeyPair::signature_consistency_check(rng, *this, "EMSA1(SHA-1)");
    }
 
 DSA_Signature_Operation::DSA_Signature_Operation(const DSA_PrivateKey& dsa) :