diff options
| author | lloyd <[email protected]> | 2010-02-17 03:17:10 +0000 |
|---|---|---|
| committer | lloyd <[email protected]> | 2010-02-17 03:17:10 +0000 |
| commit | 899d91f8f3f53cf0c19389e2a3667d93974a8a53 (patch) | |
| tree | d77d30f61e5ebdfe39db3fdfc1b530378794265a /src/math/gfpmath/gfp_element.h | |
| parent | 4f98e547994cdbb9643d096736cdd7d1e154196e (diff) | |
Remove almost entirely unnecessary friend access from GFpElement to
GFpModulus. Doing this pointed out what is probably a threading/race
bug as well: assigning to a single GFpElement causes it to reset the
GFpModulus to new values, but of course the other GFpElements don't
know about this.
Sharing the GFpModulus was a really really bad design choice by the
InSiTo folks and it needs to die. That might end up wasting a bit of
memory, but it will probably fix a lot of nasty bugs, and also remove
the use of atomic operations which in the long run is going to hurt
performance a lot worse than some extra cache use.
Diffstat (limited to 'src/math/gfpmath/gfp_element.h')
| -rw-r--r-- | src/math/gfpmath/gfp_element.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/math/gfpmath/gfp_element.h b/src/math/gfpmath/gfp_element.h index 7a8644fee..84009ef12 100644 --- a/src/math/gfpmath/gfp_element.h +++ b/src/math/gfpmath/gfp_element.h @@ -223,10 +223,6 @@ class BOTAN_DLL GFpElement */ static bool align_operands_res(const GFpElement& lhs, const GFpElement& rhs); - //friend declarations for non-member functions - - friend class Point_Coords_GFp; - /** * swaps the states of *this and other, does not throw! * @param other The value to swap with |