Remove support for block cipher padding methods in engine. Like S2K,

they were not used at all outside of the core library implementations.

One change is that now get_bc_pad returns a new object, instead of a
pointer to a const shared padding method. This does imply a bit more
dynamic memory overhead, but the modes are pretty light (stateless, for
the most part), so this doesn't seem like a big deal. So modify ECB and
CBC classes to add destructors to delete the padding object.

1 files changed, 2 insertions, 6 deletions

diff --git a/src/libstate/lookup.h b/src/libstate/lookup.h
index 34618a835..868765874 100644
--- a/src/libstate/lookup.h
+++ b/src/libstate/lookup.h
@@ -39,9 +39,6 @@ retrieve_hash(Library_State&, const std::string&);
 BOTAN_DLL const MessageAuthenticationCode*
 retrieve_mac(Library_State&, const std::string&);
 
-BOTAN_DLL const BlockCipherModePaddingMethod*
-retrieve_bc_pad(Library_State&, const std::string&);
-
 /*************************************************
 * Get an algorithm object                        *
 *************************************************/
@@ -85,12 +82,11 @@ BOTAN_DLL MessageAuthenticationCode* get_mac(const std::string& name);
 BOTAN_DLL S2K* get_s2k(const std::string& name);
 
 /**
-* Block cipher padding mode factory/retrieval method.
+* Block cipher padding mode factory method.
 * @param name the name of the desired block cipher padding mode
 * @return the block cipher padding mode object
 */
-BOTAN_DLL const BlockCipherModePaddingMethod*
-   get_bc_pad(const std::string& name);
+BOTAN_DLL BlockCipherModePaddingMethod* get_bc_pad(const std::string& name);
 
 /*************************************************
 * Get an EMSA/EME/KDF/MGF function               *