aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/tls/tls_client.cpp
diff options
context:
space:
mode:
authorJack Lloyd <[email protected]>2018-01-04 08:48:00 -0500
committerJack Lloyd <[email protected]>2018-01-21 12:56:05 -0500
commit08b7ca1d35c0e4d06695e8744708ae6cf3f5af7a (patch)
treeed1b527302608854d98a689a21d7250cb8b043ae /src/lib/tls/tls_client.cpp
parent65f375348c0773af6e9bbe3a005aef177dfd4ac3 (diff)
Remove vestigial support for TLS compression
It was never supported and never will be. Removing negotiation entirely simplifies the code a bit.
Diffstat (limited to 'src/lib/tls/tls_client.cpp')
-rw-r--r--src/lib/tls/tls_client.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/lib/tls/tls_client.cpp b/src/lib/tls/tls_client.cpp
index 631779e99..c88b6a7db 100644
--- a/src/lib/tls/tls_client.cpp
+++ b/src/lib/tls/tls_client.cpp
@@ -261,11 +261,10 @@ void Client::process_handshake_msg(const Handshake_State* active_state,
"Server replied with a signaling ciphersuite");
}
- if(!value_exists(state.client_hello()->compression_methods(),
- state.server_hello()->compression_method()))
+ if(state.server_hello()->compression_method() != 0)
{
throw TLS_Exception(Alert::HANDSHAKE_FAILURE,
- "Server replied with compression method we didn't send");
+ "Server replied with non-null compression method");
}
auto client_extn = state.client_hello()->extension_types();
@@ -609,7 +608,6 @@ void Client::process_handshake_msg(const Handshake_State* active_state,
state.session_keys().master_secret(),
state.server_hello()->version(),
state.server_hello()->ciphersuite(),
- state.server_hello()->compression_method(),
CLIENT,
state.server_hello()->supports_extended_master_secret(),
state.server_hello()->supports_encrypt_then_mac(),