diff options
| author | Jack Lloyd <[email protected]> | 2016-04-12 23:03:14 -0400 |
|---|---|---|
| committer | Jack Lloyd <[email protected]> | 2016-04-21 09:18:54 -0400 |
| commit | 8b85b7805151ab8fce5ac9d214c71c4eeb3d6075 (patch) | |
| tree | 40cbc2af481dfc2f84e32330308523a5e8f68e44 /src/lib/stream | |
| parent | a4358c96a0de1ab7afc0b437ab79bfc35f2e1824 (diff) | |
Remove Transform base class
With sufficient squinting, Transform provided an abstract base
interface that covered both cipher modes and compression algorithms.
However it mapped on neither of them particularly well. In addition
this API had the same problem that has made me dislike the Pipe/Filter
API: given a Transform&, what does it do when you put bits in? Maybe
it encrypts. Maybe it compresses. It's a floor wax and a dessert topping!
Currently the Cipher_Mode interface is left mostly unchanged, with the
APIs previously on Transform just moved down the type hierarchy. I
think there are some definite improvements possible here, wrt handling
of in-place encryption, but left for a later commit.
The compression API is split into two types, Compression_Algorithm and
Decompression_Algorithm. Compression_Algorithm's start() call takes
the compression level, allowing varying compressions with a single
object. And flushing the compression state is moved to a bool param on
`Compression_Algorithm::update`. All the nonsense WRT compression
algorithms having zero length nonces, input granularity rules, etc
as a result of using the Transform interface goes away.
Diffstat (limited to 'src/lib/stream')
| -rw-r--r-- | src/lib/stream/stream_cipher.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lib/stream/stream_cipher.h b/src/lib/stream/stream_cipher.h index 8c9b28147..bff1fd1a6 100644 --- a/src/lib/stream/stream_cipher.h +++ b/src/lib/stream/stream_cipher.h @@ -8,7 +8,6 @@ #ifndef BOTAN_STREAM_CIPHER_H__ #define BOTAN_STREAM_CIPHER_H__ -#include <botan/transform.h> #include <botan/sym_algo.h> #include <botan/scan_name.h> |