V816 It is more efficient to catch exception by reference rather than by value. asn1_time.cpp 159

4 files changed, 4 insertions, 4 deletions

diff --git a/src/lib/pubkey/keypair/keypair.cpp b/src/lib/pubkey/keypair/keypair.cpp
index ef211ffd4..0f5a48541 100644
--- a/src/lib/pubkey/keypair/keypair.cpp
+++ b/src/lib/pubkey/keypair/keypair.cpp
@@ -59,7 +59,7 @@ bool signature_consistency_check(RandomNumberGenerator& rng,
       {
       signature = signer.sign_message(message, rng);
       }
-   catch(Encoding_Error)
+   catch(Encoding_Error&)
       {
       return false;
       }
diff --git a/src/lib/pubkey/mceies/mceies.cpp b/src/lib/pubkey/mceies/mceies.cpp
index 0af71719a..95042e529 100644
--- a/src/lib/pubkey/mceies/mceies.cpp
+++ b/src/lib/pubkey/mceies/mceies.cpp
@@ -98,7 +98,7 @@ mceies_decrypt(const McEliece_PrivateKey& privkey,
       aead->finish(pt, 0);
       return pt;
       }
-   catch(Integrity_Failure)
+   catch(Integrity_Failure&)
       {
       throw;
       }
diff --git a/src/lib/pubkey/pk_keys.cpp b/src/lib/pubkey/pk_keys.cpp
index 635934037..ebaa0eb69 100644
--- a/src/lib/pubkey/pk_keys.cpp
+++ b/src/lib/pubkey/pk_keys.cpp
@@ -19,7 +19,7 @@ OID Public_Key::get_oid() const
    try {
       return OIDS::lookup(algo_name());
       }
-   catch(Lookup_Error)
+   catch(Lookup_Error&)
       {
       throw Lookup_Error("PK algo " + algo_name() + " has no defined OIDs");
       }
diff --git a/src/lib/pubkey/pubkey.cpp b/src/lib/pubkey/pubkey.cpp
index 37408272a..d3b711f1e 100644
--- a/src/lib/pubkey/pubkey.cpp
+++ b/src/lib/pubkey/pubkey.cpp
@@ -231,7 +231,7 @@ bool PK_Verifier::check_signature(const byte sig[], size_t length)
          throw Decoding_Error("PK_Verifier: Unknown signature format " +
                               std::to_string(m_sig_format));
       }
-   catch(Invalid_Argument) { return false; }
+   catch(Invalid_Argument&) { return false; }
    }
 
 }