Content:

* fixes for deprecated constructions in c++11 and later (explicit rule of 3/5 or implicit rule of 0 and other violations)
* `default` specifier instead of `{}` in some places(probably all)
* removal of unreachable code (for example `return` after `throw`)
* removal of compilation unit only visible, but not used functions
* fix for `throw()` specifier - used instead `BOTAN_NOEXCEPT`
* removed not needed semicolons

1 files changed, 0 insertions, 17 deletions

diff --git a/src/lib/pubkey/pk_ops.cpp b/src/lib/pubkey/pk_ops.cpp
index cf10c4ba2..5c864d966 100644
--- a/src/lib/pubkey/pk_ops.cpp
+++ b/src/lib/pubkey/pk_ops.cpp
@@ -6,9 +6,6 @@
 */
 
 #include <botan/internal/pk_ops_impl.h>
-#include <botan/eme.h>
-#include <botan/kdf.h>
-#include <botan/emsa.h>
 #include <botan/internal/bit_ops.h>
 
 namespace Botan {
@@ -20,8 +17,6 @@ PK_Ops::Encryption_with_EME::Encryption_with_EME(const std::string& eme)
       throw Algorithm_Not_Found(eme);
    }
 
-PK_Ops::Encryption_with_EME::~Encryption_with_EME() {}
-
 size_t PK_Ops::Encryption_with_EME::max_input_bits() const
    {
    return m_eme->maximum_input_size(max_raw_input_bits());
@@ -42,8 +37,6 @@ PK_Ops::Decryption_with_EME::Decryption_with_EME(const std::string& eme)
       throw Algorithm_Not_Found(eme);
    }
 
-PK_Ops::Decryption_with_EME::~Decryption_with_EME() {}
-
 secure_vector<uint8_t>
 PK_Ops::Decryption_with_EME::decrypt(uint8_t& valid_mask,
                                      const uint8_t ciphertext[],
@@ -59,8 +52,6 @@ PK_Ops::Key_Agreement_with_KDF::Key_Agreement_with_KDF(const std::string& kdf)
       m_kdf.reset(get_kdf(kdf));
    }
 
-PK_Ops::Key_Agreement_with_KDF::~Key_Agreement_with_KDF() {}
-
 secure_vector<uint8_t> PK_Ops::Key_Agreement_with_KDF::agree(size_t key_len,
                                                           const uint8_t w[], size_t w_len,
                                                           const uint8_t salt[], size_t salt_len)
@@ -81,8 +72,6 @@ PK_Ops::Signature_with_EMSA::Signature_with_EMSA(const std::string& emsa) :
       throw Algorithm_Not_Found(emsa);
    }
 
-PK_Ops::Signature_with_EMSA::~Signature_with_EMSA() {}
-
 void PK_Ops::Signature_with_EMSA::update(const uint8_t msg[], size_t msg_len)
    {
    if(has_prefix() && !m_prefix_used)
@@ -112,8 +101,6 @@ PK_Ops::Verification_with_EMSA::Verification_with_EMSA(const std::string& emsa)
       throw Algorithm_Not_Found(emsa);
    }
 
-PK_Ops::Verification_with_EMSA::~Verification_with_EMSA() {}
-
 void PK_Ops::Verification_with_EMSA::update(const uint8_t msg[], size_t msg_len)
    {
    if(has_prefix() && !m_prefix_used)
@@ -163,8 +150,6 @@ PK_Ops::KEM_Encryption_with_KDF::KEM_Encryption_with_KDF(const std::string& kdf)
    m_kdf.reset(get_kdf(kdf));
    }
 
-PK_Ops::KEM_Encryption_with_KDF::~KEM_Encryption_with_KDF() {}
-
 secure_vector<uint8_t>
 PK_Ops::KEM_Decryption_with_KDF::kem_decrypt(const uint8_t encap_key[],
                                              size_t len,
@@ -184,6 +169,4 @@ PK_Ops::KEM_Decryption_with_KDF::KEM_Decryption_with_KDF(const std::string& kdf)
    m_kdf.reset(get_kdf(kdf));
    }
 
-PK_Ops::KEM_Decryption_with_KDF::~KEM_Decryption_with_KDF() {}
-
 }