Store base point multiplies in a single std::vector

Since the point is public all the values are also, so this reduces
pressure on the mlock allocator and may (slightly) help perf through
cache read-ahead.

Downside is cache based side channels are slightly easier (vs the
data being stored in discontigious vectors). But we shouldn't rely
on that in any case. And having it be in an array makes a masked
table lookup easier to arrange.

1 files changed, 8 insertions, 0 deletions

diff --git a/src/lib/pubkey/ec_group/point_gfp.h b/src/lib/pubkey/ec_group/point_gfp.h
index aa7e5b2c0..80c198c62 100644
--- a/src/lib/pubkey/ec_group/point_gfp.h
+++ b/src/lib/pubkey/ec_group/point_gfp.h
@@ -148,6 +148,10 @@ class BOTAN_PUBLIC_API(2,0) PointGFp final
       */
       BigInt get_affine_y() const;
 
+      const BigInt& get_x() const { return m_coord_x; }
+      const BigInt& get_y() const { return m_coord_y; }
+      const BigInt& get_z() const { return m_coord_z; }
+
       /**
       * Force this point to affine coordinates
       */
@@ -211,6 +215,10 @@ class BOTAN_PUBLIC_API(2,0) PointGFp final
       */
       void add_affine(const PointGFp& other, std::vector<BigInt>& workspace);
 
+      void add_affine(const word x_words[], size_t x_size,
+                      const word y_words[], size_t y_size,
+                      std::vector<BigInt>& workspace);
+
       /**
       * Point doubling
       * @param workspace temp space, at least WORKSPACE_SIZE elements