Realization while thinking about the recently added truncate: in a STL

container like vector, truncate is simply resize, but what
MemoryRegion called resize will zap the entire contents, and then what
was resize was called grow_to. This is really problematic in terms of
the goal of replacing MemoryRegion with a vector with a custom
allocator.

In this checkin:
  - Remove MemoryRegion::grow_to and MemoryRegion::truncate

  - Change the semantics of MemoryRegion::resize to change the size
    while keeping any current contents intact (up to the new size),
    zero initializing any new values.

Unrelated, just noticed the lack while I was in there, add a version
of CryptoBox::decrypt taking a std::string for the input.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/codec/hex/hex.cpp b/src/codec/hex/hex.cpp
index 70e819906..6cef71fec 100644
--- a/src/codec/hex/hex.cpp
+++ b/src/codec/hex/hex.cpp
@@ -167,7 +167,7 @@ SecureVector<byte> hex_decode(const char input[],
                                input_length,
                                ignore_ws);
 
-   bin.truncate(written);
+   bin.resize(written);
    return bin;
    }