Add final attribute to many classes

In some cases this can offer better optimization, via devirtualization.
And it lets the user know the class is not intended for derivation.

Some discussion in GH #402

11 files changed, 33 insertions, 33 deletions

diff --git a/src/cli/asn1.cpp b/src/cli/asn1.cpp
index 3af2be97d..34e2fe870 100644
--- a/src/cli/asn1.cpp
+++ b/src/cli/asn1.cpp
@@ -356,7 +356,7 @@ void decode(Botan::BER_Decoder& decoder, size_t level)
 
 }
 
-class ASN1_Printer : public Command
+class ASN1_Printer final : public Command
    {
    public:
       ASN1_Printer() : Command("asn1print file") {}
diff --git a/src/cli/bench.cpp b/src/cli/bench.cpp
index 4f1986de6..529f89baf 100644
--- a/src/cli/bench.cpp
+++ b/src/cli/bench.cpp
@@ -240,7 +240,7 @@ std::vector<std::string> default_benchmark_list()
 
 }
 
-class Benchmark : public Command
+class Benchmark final : public Command
    {
    public:
       Benchmark() : Command("bench --msec=1000 --provider= --buf-size=8 *algos") {}
diff --git a/src/cli/cc_enc.cpp b/src/cli/cc_enc.cpp
index 2e2f9c12a..6f19e546c 100644
--- a/src/cli/cc_enc.cpp
+++ b/src/cli/cc_enc.cpp
@@ -104,7 +104,7 @@ uint64_t decrypt_cc_number(uint64_t enc_cc,
 
 }
 
-class CC_Encrypt : public Command
+class CC_Encrypt final : public Command
    {
    public:
       CC_Encrypt() : Command("cc_encrypt CC passphrase --tweak=") {}
@@ -130,7 +130,7 @@ class CC_Encrypt : public Command
 
 BOTAN_REGISTER_COMMAND("cc_encrypt", CC_Encrypt);
 
-class CC_Decrypt : public Command
+class CC_Decrypt final : public Command
    {
    public:
       CC_Decrypt() : Command("cc_decrypt CC passphrase --tweak=") {}
diff --git a/src/cli/compress.cpp b/src/cli/compress.cpp
index 0d29dc180..c573eaa20 100644
--- a/src/cli/compress.cpp
+++ b/src/cli/compress.cpp
@@ -43,7 +43,7 @@ void do_compress(Botan::Transform& comp,
 
 }
 
-class Compress : public Command
+class Compress final : public Command
    {
    public:
       Compress() : Command("compress --type=gzip --level=6 --buf-size=8192 file") {}
@@ -103,7 +103,7 @@ class Compress : public Command
 
 BOTAN_REGISTER_COMMAND("compress", Compress);
 
-class Decompress : public Command
+class Decompress final : public Command
    {
    public:
       Decompress() : Command("decompress --buf-size=8192 file") {}
diff --git a/src/cli/math.cpp b/src/cli/math.cpp
index 27f3660d1..4ed58b9f0 100644
--- a/src/cli/math.cpp
+++ b/src/cli/math.cpp
@@ -14,7 +14,7 @@
 
 namespace Botan_CLI {
 
-class Gen_Prime : public Command
+class Gen_Prime final : public Command
    {
    public:
       Gen_Prime() : Command("gen_prime --count=1 bits") {}
@@ -34,7 +34,7 @@ class Gen_Prime : public Command
 
 BOTAN_REGISTER_COMMAND("gen_prime", Gen_Prime);
 
-class Is_Prime : public Command
+class Is_Prime final : public Command
    {
    public:
       Is_Prime() : Command("is_prime --prob=56 n") {}
@@ -55,7 +55,7 @@ BOTAN_REGISTER_COMMAND("is_prime", Is_Prime);
 * Factor integers using a combination of trial division by small
 * primes, and Pollard's Rho algorithm
 */
-class Factor : public Command
+class Factor final : public Command
    {
    public:
       Factor() : Command("factor n") {}
diff --git a/src/cli/pubkey.cpp b/src/cli/pubkey.cpp
index 93a36a9cc..cc02e02fc 100644
--- a/src/cli/pubkey.cpp
+++ b/src/cli/pubkey.cpp
@@ -41,7 +41,7 @@
 
 namespace Botan_CLI {
 
-class PK_Keygen : public Command
+class PK_Keygen final : public Command
    {
    public:
       PK_Keygen() : Command("keygen --algo=RSA --params= --passphrase= --pbe= --pbe-millis=300 --der-out") {}
@@ -164,7 +164,7 @@ std::string algo_default_emsa(const std::string& key)
 
 }
 
-class PK_Sign : public Command
+class PK_Sign final : public Command
    {
    public:
       PK_Sign() : Command("sign --passphrase= --hash=SHA-256 --emsa= key file") {}
@@ -192,7 +192,7 @@ class PK_Sign : public Command
 
 BOTAN_REGISTER_COMMAND("sign", PK_Sign);
 
-class PK_Verify : public Command
+class PK_Verify final : public Command
    {
    public:
       PK_Verify() : Command("verify --hash=SHA-256 --emsa= pubkey file signature") {}
@@ -223,7 +223,7 @@ BOTAN_REGISTER_COMMAND("verify", PK_Verify);
 
 #if defined(BOTAN_HAS_DL_GROUP)
 
-class Gen_DL_Group : public Command
+class Gen_DL_Group final : public Command
    {
    public:
       Gen_DL_Group() : Command("gen_dl_group --pbits=1024 --qbits=0 --type=subgroup") {}
@@ -253,7 +253,7 @@ BOTAN_REGISTER_COMMAND("gen_dl_group", Gen_DL_Group);
 
 #endif
 
-class PKCS8_Tool : public Command
+class PKCS8_Tool final : public Command
    {
    public:
       PKCS8_Tool() : Command("pkcs8 --pass-in= --pub-out --der-out --pass-out= --pbe= --pbe-millis=300 key") {}
diff --git a/src/cli/tls_client.cpp b/src/cli/tls_client.cpp
index bf1c3a57c..a16f1ef88 100644
--- a/src/cli/tls_client.cpp
+++ b/src/cli/tls_client.cpp
@@ -35,7 +35,7 @@
 
 namespace Botan_CLI {
 
-class TLS_Client : public Command
+class TLS_Client final : public Command
    {
    public:
       TLS_Client() : Command("tls_client host --port=443 --type=tcp "
diff --git a/src/cli/tls_proxy.cpp b/src/cli/tls_proxy.cpp
index 83332bb49..2c92ad281 100644
--- a/src/cli/tls_proxy.cpp
+++ b/src/cli/tls_proxy.cpp
@@ -384,7 +384,7 @@ class tls_proxy_server
 
 }
 
-class TLS_Proxy : public Command
+class TLS_Proxy final : public Command
    {
    public:
       TLS_Proxy() : Command("tls_proxy listen_port target_host target_port server_cert server_key "
diff --git a/src/cli/tls_server.cpp b/src/cli/tls_server.cpp
index ccf8f40ac..c802dbeb0 100644
--- a/src/cli/tls_server.cpp
+++ b/src/cli/tls_server.cpp
@@ -30,7 +30,7 @@
 
 namespace Botan_CLI {
 
-class TLS_Server : public Command
+class TLS_Server final : public Command
    {
    public:
       TLS_Server() : Command("tls_server cert key --port=443 --type=tcp") {}
diff --git a/src/cli/utils.cpp b/src/cli/utils.cpp
index 526b59aba..3f59ee923 100644
--- a/src/cli/utils.cpp
+++ b/src/cli/utils.cpp
@@ -30,7 +30,7 @@
 
 namespace Botan_CLI {
 
-class Config_Info : public Command
+class Config_Info final : public Command
    {
    public:
       Config_Info() : Command("config info_type") {}
@@ -74,7 +74,7 @@ class Config_Info : public Command
 
 BOTAN_REGISTER_COMMAND("config", Config_Info);
 
-class Version_Info : public Command
+class Version_Info final : public Command
    {
    public:
       Version_Info() : Command("version --full") {}
@@ -96,7 +96,7 @@ class Version_Info : public Command
 
 BOTAN_REGISTER_COMMAND("version", Version_Info);
 
-class Print_Cpuid : public Command
+class Print_Cpuid final : public Command
    {
    public:
       Print_Cpuid() : Command("cpuid") {}
@@ -109,7 +109,7 @@ class Print_Cpuid : public Command
 
 BOTAN_REGISTER_COMMAND("cpuid", Print_Cpuid);
 
-class Hash : public Command
+class Hash final : public Command
    {
    public:
       Hash() : Command("hash --algo=SHA-256 --buf-size=4096 *files") {}
@@ -146,7 +146,7 @@ class Hash : public Command
 
 BOTAN_REGISTER_COMMAND("hash", Hash);
 
-class RNG : public Command
+class RNG final : public Command
    {
    public:
       RNG() : Command("rng bytes --system") {}
@@ -175,7 +175,7 @@ BOTAN_REGISTER_COMMAND("rng", RNG);
 
 #if defined(BOTAN_HAS_HTTP_UTIL)
 
-class HTTP_Get : public Command
+class HTTP_Get final : public Command
    {
    public:
       HTTP_Get() : Command("http_get url") {}
@@ -192,7 +192,7 @@ BOTAN_REGISTER_COMMAND("http_get", HTTP_Get);
 
 #if defined(BOTAN_HAS_BASE64_CODEC)
 
-class Base64_Encode : public Command
+class Base64_Encode final : public Command
    {
    public:
       Base64_Encode() : Command("base64_enc file") {}
@@ -207,7 +207,7 @@ class Base64_Encode : public Command
 
 BOTAN_REGISTER_COMMAND("base64_enc", Base64_Encode);
 
-class Base64_Decode : public Command
+class Base64_Decode final : public Command
    {
    public:
       Base64_Decode() : Command("base64_dec file") {}
@@ -232,7 +232,7 @@ BOTAN_REGISTER_COMMAND("base64_dec", Base64_Decode);
 
 #if defined(BOTAN_HAS_BCRYPT)
 
-class Generate_Bcrypt : public Command
+class Generate_Bcrypt final : public Command
    {
    public:
       Generate_Bcrypt() : Command("gen_bcrypt --work-factor=12 password") {}
@@ -248,7 +248,7 @@ class Generate_Bcrypt : public Command
 
 BOTAN_REGISTER_COMMAND("gen_bcrypt", Generate_Bcrypt);
 
-class Check_Bcrypt : public Command
+class Check_Bcrypt final : public Command
    {
    public:
       Check_Bcrypt() : Command("check_bcrypt password hash") {}
diff --git a/src/cli/x509.cpp b/src/cli/x509.cpp
index 886b57259..665a3ebc5 100644
--- a/src/cli/x509.cpp
+++ b/src/cli/x509.cpp
@@ -21,7 +21,7 @@
 
 namespace Botan_CLI {
 
-class Sign_Cert : public Command
+class Sign_Cert final : public Command
    {
    public:
       Sign_Cert() : Command("sign_cert --ca-key-pass= --hash=SHA-256 "
@@ -60,7 +60,7 @@ class Sign_Cert : public Command
 
 BOTAN_REGISTER_COMMAND("sign_cert", Sign_Cert);
 
-class Cert_Info : public Command
+class Cert_Info final : public Command
    {
    public:
       Cert_Info() : Command("cert_info file") {}
@@ -75,7 +75,7 @@ class Cert_Info : public Command
 BOTAN_REGISTER_COMMAND("cert_info", Cert_Info);
 
 #if defined(BOTAN_HAS_OCSP)
-class OCSP_Check : public Command
+class OCSP_Check final : public Command
    {
    public:
       OCSP_Check() : Command("ocsp_check subject issuer") {}
@@ -107,7 +107,7 @@ BOTAN_REGISTER_COMMAND("ocsp_check", OCSP_Check);
 
 #endif // OCSP
 
-class Cert_Verify : public Command
+class Cert_Verify final : public Command
    {
    public:
       Cert_Verify() : Command("cert_verify subject *ca_certs") {}
@@ -142,7 +142,7 @@ class Cert_Verify : public Command
 
 BOTAN_REGISTER_COMMAND("cert_verify", Cert_Verify);
 
-class Gen_Self_Signed : public Command
+class Gen_Self_Signed final : public Command
    {
    public:
       Gen_Self_Signed() : Command("gen_self_signed key CN --country= --dns= "
@@ -178,7 +178,7 @@ class Gen_Self_Signed : public Command
 
 BOTAN_REGISTER_COMMAND("gen_self_signed", Gen_Self_Signed);
 
-class Generate_PKCS10 : public Command
+class Generate_PKCS10 final : public Command
    {
    public:
       Generate_PKCS10() : Command("gen_pkcs10 key CN --country= --organization= "